Use service builder for DriverFinder

SeleniumHQ · Apr 26, 2024 · 9b3fc36 · 9b3fc36
1 parent bf24f19
commit 9b3fc36
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/examples/ruby/spec/browsers/chrome_spec.rb b/examples/ruby/spec/browsers/chrome_spec.rb
@@ -115,7 +115,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
-    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service.new)
+    service = Selenium::WebDriver::Service.chrome
+    finder = Selenium::WebDriver::DriverFinder.new(options, service)
     ENV['CHROMEDRIVER_BIN'] = finder.driver_path
     ENV['CHROME_BIN'] = finder.browser_path
   end

diff --git a/examples/ruby/spec/browsers/edge_spec.rb b/examples/ruby/spec/browsers/edge_spec.rb
@@ -115,7 +115,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.edge(browser_version: 'stable')
-    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Edge::Service.new)
+    service = Selenium::WebDriver::Service.edge
+    finder = Selenium::WebDriver::DriverFinder.new(options, service)
     ENV['EDGEDRIVER_BIN'] = finder.driver_path
     ENV['EDGE_BIN'] = finder.browser_path
   end

diff --git a/examples/ruby/spec/browsers/firefox_spec.rb b/examples/ruby/spec/browsers/firefox_spec.rb
@@ -122,7 +122,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.firefox(browser_version: 'stable')
-    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Firefox::Service.new)
+    service = Selenium::WebDriver::Service.firefox
+    finder = Selenium::WebDriver::DriverFinder.new(options, service)
     ENV['GECKODRIVER_BIN'] = finder.driver_path
     ENV['FIREFOX_BIN'] = finder.browser_path
   end

diff --git a/examples/ruby/spec/drivers/service_spec.rb b/examples/ruby/spec/drivers/service_spec.rb
@@ -33,7 +33,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
-    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service.new)
+    service = Selenium::WebDriver::Service.chrome
+    finder = Selenium::WebDriver::DriverFinder.new(options, service)
     ENV['CHROMEDRIVER_BIN'] = finder.driver_path
     ENV['CHROME_BIN'] = finder.browser_path
   end