Update Custom Node Initialization in Grid Advanced Features (#1729)

* Update Code Sample * Fix identation * Fix constructor * Fix typo * Fix identation --------- Co-authored-by: Diego Molina <[email protected]> [deploy site]
SeleniumHQ · May 17, 2024 · 808af3e · 808af3e
1 parent dd2daa7
commit 808af3e
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 20 deletions.
diff --git a/website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md b/website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md
@@ -95,23 +95,26 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
-	super(tracer, nodeId, uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret, Duration sessionTimeout) {
+    super(tracer, nodeId, uri, registrationSecret, sessionTimeout);
   }
 
   public static Node create(Config config) {
     LoggingOptions loggingOptions = new LoggingOptions(config);
     BaseServerOptions serverOptions = new BaseServerOptions(config);
     URI uri = serverOptions.getExternalUri();
     SecretOptions secretOptions = new SecretOptions(config);
+    NodeOptions nodeOptions = new NodeOptions(config);
+    Duration sessionTimeout = nodeOptions.getSessionTimeout();
 
     // Refer to the foot notes for additional context on this line.
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-				node.getId(),
-				uri,
-				secretOptions.getRegistrationSecret());
+        node.getId(),
+        uri,
+        secretOptions.getRegistrationSecret(),
+        sessionTimeout);
     wrapper.node = node;
     return wrapper;
   }

diff --git a/website_and_docs/content/documentation/grid/advanced_features/customize_node.ja.md b/website_and_docs/content/documentation/grid/advanced_features/customize_node.ja.md
@@ -100,23 +100,26 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
-	super(tracer, nodeId, uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret, Duration sessionTimeout) {
+    super(tracer, nodeId, uri, registrationSecret, sessionTimeout);
   }
 
   public static Node create(Config config) {
     LoggingOptions loggingOptions = new LoggingOptions(config);
     BaseServerOptions serverOptions = new BaseServerOptions(config);
     URI uri = serverOptions.getExternalUri();
     SecretOptions secretOptions = new SecretOptions(config);
+    NodeOptions nodeOptions = new NodeOptions(config);
+    Duration sessionTimeout = nodeOptions.getSessionTimeout();
 
     // Refer to the foot notes for additional context on this line.
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-				node.getId(),
-				uri,
-				secretOptions.getRegistrationSecret());
+        node.getId(),
+        uri,
+        secretOptions.getRegistrationSecret(),
+        sessionTimeout);
     wrapper.node = node;
     return wrapper;
   }

diff --git a/...e_and_docs/content/documentation/grid/advanced_features/customize_node.pt-br.md b/...e_and_docs/content/documentation/grid/advanced_features/customize_node.pt-br.md
@@ -90,23 +90,26 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
-	super(tracer, nodeId, uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret, Duration sessionTimeout) {
+    super(tracer, nodeId, uri, registrationSecret, sessionTimeout);
   }
 
   public static Node create(Config config) {
     LoggingOptions loggingOptions = new LoggingOptions(config);
     BaseServerOptions serverOptions = new BaseServerOptions(config);
     URI uri = serverOptions.getExternalUri();
     SecretOptions secretOptions = new SecretOptions(config);
+    NodeOptions nodeOptions = new NodeOptions(config);
+    Duration sessionTimeout = nodeOptions.getSessionTimeout();
 
     // Refer to the foot notes for additional context on this line.
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-				node.getId(),
-				uri,
-				secretOptions.getRegistrationSecret());
+        node.getId(),
+        uri,
+        secretOptions.getRegistrationSecret(),
+        sessionTimeout);
     wrapper.node = node;
     return wrapper;
   }

diff --git a/...e_and_docs/content/documentation/grid/advanced_features/customize_node.zh-cn.md b/...e_and_docs/content/documentation/grid/advanced_features/customize_node.zh-cn.md
@@ -100,23 +100,26 @@ public class DecoratedLoggingNode extends Node {
 
   private Node node;
 
-  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret) {
-	super(tracer, nodeId, uri, registrationSecret);
+  protected DecoratedLoggingNode(Tracer tracer, NodeId nodeId, URI uri, Secret registrationSecret, Duration sessionTimeout) {
+    super(tracer, nodeId, uri, registrationSecret, sessionTimeout);
   }
 
   public static Node create(Config config) {
     LoggingOptions loggingOptions = new LoggingOptions(config);
     BaseServerOptions serverOptions = new BaseServerOptions(config);
     URI uri = serverOptions.getExternalUri();
     SecretOptions secretOptions = new SecretOptions(config);
+    NodeOptions nodeOptions = new NodeOptions(config);
+    Duration sessionTimeout = nodeOptions.getSessionTimeout();
 
     // Refer to the foot notes for additional context on this line.
     Node node = LocalNodeFactory.create(config);
 
     DecoratedLoggingNode wrapper = new DecoratedLoggingNode(loggingOptions.getTracer(),
-				node.getId(),
-				uri,
-				secretOptions.getRegistrationSecret());
+        node.getId(),
+        uri,
+        secretOptions.getRegistrationSecret(),
+        sessionTimeout);
     wrapper.node = node;
     return wrapper;
   }