-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Support running Ruby tests in RBE for Chrome #13661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Bazel bits look good to me. A couple of questions, but we an always iterate :)
CI Failure Feedback(Checks updated until commit 1ecf9a4)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
Persistent checks updated to latest commit fb154e3 |
1 similar comment
Persistent checks updated to latest commit fb154e3 |
Persistent checks updated to latest commit f1640a5 |
1 similar comment
Persistent checks updated to latest commit f1640a5 |
Persistent checks updated to latest commit 3db5b0e |
Persistent checks updated to latest commit c4506ea |
3 similar comments
Persistent checks updated to latest commit c4506ea |
Persistent checks updated to latest commit c4506ea |
Persistent checks updated to latest commit c4506ea |
This fixes broken build on Windows failing with: ERROR: C:/tmp/5rcabgft/external/rules_java_builtin/toolchains/BUILD:283:27: While resolving toolchains for target @@rules_java_builtin//toolchains:remotejdk_21 (c81c515): No matching toolchains found for types @@bazel_tools//tools/jdk:runtime_toolchain_type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13661 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 86 86
Lines 5270 5270
Branches 220 220
=======================================
Hits 3082 3082
Misses 1968 1968
Partials 220 220 ☔ View full report in Codecov by Sentry. |
Hooks Ruby integration tests into RBE. For now, only Chrome is being tested, but I'm going to follow the Java approach and generate separate targets for each browser in the coming PRs:
Successful build - https://gypsum.cluster.engflow.com/invocations/default/88e8242b-d89a-4a1e-879e-6beb468c53a7. There are service tests failing due to SM invocation, so these targets are added to
.skipped-tests
.