Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes 171 #174

Closed
wants to merge 2 commits into from
Closed

fixes 171 #174

wants to merge 2 commits into from

Conversation

J3fftw1
Copy link

@J3fftw1 J3fftw1 commented Oct 8, 2022

please gimme hacktoberfest accepted
Resolves #171

Sefiraat
Sefiraat reviewed Oct 8, 2022
View reviewed changes
Copy link
Owner

@Sefiraat Sefiraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same check to the overload as well? That should be good to merge then

@J3fftw1 J3fftw1 requested a review from Sefiraat October 8, 2022 19:56
@J3fftw1
Copy link
Author

J3fftw1 commented Mar 6, 2023

@Sefiraat please merge

@J3fftw1 J3fftw1 closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sefiraat Sefiraat Awaiting requested review from Sefiraat

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spamming console error
2 participants
@J3fftw1 @Sefiraat