Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #2360

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix typos #2360

merged 2 commits into from
Oct 4, 2024

Conversation

AlvaroParker
Copy link
Contributor

PR Info

Fix typos on source code and docs using typos cli.

I only left one typo on CHANGELOG.md which I don't know if it's ok to edit, if it is let me know and I add it to the commit.

error: `boths` should be `both`
  --> ./CHANGELOG.md:653:4
    |
653 | // boths yields `Vec<(E::Model, Vec<F::Model>)>`
    |    ^^^^^
    |

Note: Maybe add a workflow to check for typos on pull requests

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! Thanks! @AlvaroParker

@billy1624 billy1624 merged commit bfd21e9 into SeaQL:master Oct 4, 2024
32 checks passed
Copy link

github-actions bot commented Oct 4, 2024

🎉 Released In 1.1.0-rc.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Copy link

🎉 Released In 1.1.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants