-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: beforeAll test funcs #54
Merged
garyghayrat
merged 11 commits into
feat/increase-test-coverage
from
feat/before-test-funcs
May 2, 2024
Merged
feat: beforeAll test funcs #54
garyghayrat
merged 11 commits into
feat/increase-test-coverage
from
feat/before-test-funcs
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 12, 2024
Closed
garyghayrat
reviewed
Apr 16, 2024
src/lib/actions/watchAnnouncementsForUser/watchAnnouncementsForUser.test.ts
Outdated
Show resolved
Hide resolved
garyghayrat
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but don't merge yet.
* feat: biome * chore: biome format * chore: biome no trailing comma * chore: format examples with biome * chore: format * feat: biome format * feat: biome lint script * feat: biome check * fix: lint errors * feat: remove lint since build already runs biome check * chore: format * feat: apply * chore: import sort * fix: use biome * feat: deterministic gen stealth meta address (#60) * fix: valid compressed key input type clarity * fix: comment and variable clarity * feat: get stealth meta address from keys * feat: is valid pub key * feat: is valid key tests * feat: gen keys from sig * chore: default export * chore: fix import * fix: test * feat: extract portions into own func for testing * feat: get stealth meta address from signature * feat: test * feat: example for gen stealth meta address from sig * chore: lint * fix: comment * feat: change get to generate (verbiage) * fix: generate verbiage * chore: clean * Update examples/generateDeterministicStealthMetaAddress/README.md Co-authored-by: Gary Ghayrat <[email protected]> * feat: send and receive test (#62) * feat: handle just passing the stealth meta-address directly * chore: format * chore: format * feat: send and receive test * chore: format * chore: comment * chore: comment * chore: clean * chore: clean * fix: just wait for the receipt --------- Co-authored-by: Gary Ghayrat <[email protected]> * fix: ci workflow for check * fix: dont apply with check * fix: check to end * chore: check --------- Co-authored-by: Gary Ghayrat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the tests to correctly use
beforeAll
testing lifecycle hooks, which will now throw errors if anything within the hook throws an error (unlike before where tests would be omitted with any errors within the describe hook and not withintest
. tldr and for posterity: describe hooks should not have async code.also, updates the large dataset test within
getAnnouncements
to now use 100 announcements (instead of 1000), for testing speed.also, updates to remove all of the logs throughout the tests for ease of reviewing tests.