Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: beforeAll test funcs #54

Merged
merged 11 commits into from
May 2, 2024

Conversation

marcomariscal
Copy link
Collaborator

@marcomariscal marcomariscal commented Apr 12, 2024

updates the tests to correctly use beforeAll testing lifecycle hooks, which will now throw errors if anything within the hook throws an error (unlike before where tests would be omitted with any errors within the describe hook and not within test. tldr and for posterity: describe hooks should not have async code.

also, updates the large dataset test within getAnnouncements to now use 100 announcements (instead of 1000), for testing speed.

also, updates to remove all of the logs throughout the tests for ease of reviewing tests.

@marcomariscal marcomariscal changed the base branch from main to feat/increase-test-coverage April 12, 2024 22:16
@marcomariscal marcomariscal linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but don't merge yet.

* feat: biome

* chore: biome format

* chore: biome no trailing comma

* chore: format examples with biome

* chore: format

* feat: biome format

* feat: biome lint script

* feat: biome check

* fix: lint errors

* feat: remove lint since build already runs biome check

* chore: format

* feat: apply

* chore: import sort

* fix: use biome

* feat: deterministic gen stealth meta address (#60)

* fix: valid compressed key input type clarity

* fix: comment and variable clarity

* feat: get stealth meta address from keys

* feat: is valid pub key

* feat: is valid key tests

* feat: gen keys from sig

* chore: default export

* chore: fix import

* fix: test

* feat: extract portions into own func for testing

* feat: get stealth meta address from signature

* feat: test

* feat: example for gen stealth meta address from sig

* chore: lint

* fix: comment

* feat: change get to generate (verbiage)

* fix: generate verbiage

* chore: clean

* Update examples/generateDeterministicStealthMetaAddress/README.md

Co-authored-by: Gary Ghayrat <[email protected]>

* feat: send and receive test (#62)

* feat: handle just passing the stealth meta-address directly

* chore: format

* chore: format

* feat: send and receive test

* chore: format

* chore: comment

* chore: comment

* chore: clean

* chore: clean

* fix: just wait for the receipt

---------

Co-authored-by: Gary Ghayrat <[email protected]>

* fix: ci workflow for check

* fix: dont apply with check

* fix: check to end

* chore: check

---------

Co-authored-by: Gary Ghayrat <[email protected]>
@garyghayrat garyghayrat merged commit f0ad178 into feat/increase-test-coverage May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants