Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest torch, add caveats to README, add some small things #37

Merged
merged 19 commits into from
Oct 11, 2023

Conversation

Vindaar
Copy link
Member

@Vindaar Vindaar commented Feb 5, 2022

  • wraps a few more things:
    • tanh, tanh_mut
    • deviceCount
    • TensorDataset, toDataset

and updates the torch downloader to get the latest version by default (1.10.2 libtorch with CUDA 11.3).

And add a section in the README about the {.noInit.} problems & CUDA support.

@Vindaar Vindaar closed this Sep 14, 2022
@Vindaar Vindaar reopened this Sep 14, 2022
@Vindaar Vindaar force-pushed the updateTorchMiscAdditions branch from c156a24 to 5565a44 Compare April 26, 2023 08:47
(for RawTensor). Can lead to overload reslution issues for RawTensor.
@HugoGranstrom
Copy link
Member

And add a section in the README about the {.noInit.} problems

This would be outdated now with Nim 2.0 🥳

@Vindaar
Copy link
Member Author

Vindaar commented Aug 9, 2023

Heh, it's really time I finish this now. But only a matter of a bit, because soon I will need to have some git tags for my thesis anyway. 🤣

@Clonkk
Copy link
Member

Clonkk commented Oct 11, 2023

With Nim 2.0 out, the testsuite works.

@Vindaar it's time to merge this :)

@Vindaar
Copy link
Member Author

Vindaar commented Oct 11, 2023

Ah, I once again forgot this still needs to be merged! Let me check if there's still something uncommited locally.

@Clonkk
Copy link
Member

Clonkk commented Oct 11, 2023

I finished pushing my local change from last time :).

When it's ok for you and CI is happy let's merge this

Using the weight field directly does not work. Use the `weight=`
procedure instead to assign the weight.
@Vindaar Vindaar merged commit b29925d into master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants