Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metabase scalingo/csv plugin support #14

Closed
wants to merge 16 commits into from
Closed

Feature/metabase scalingo/csv plugin support #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f9284af
Update .buildpacks
jdauphant May 16, 2021
a69f66e
Download CSV plugin
jdauphant May 16, 2021
4d14f16
Update compile
jdauphant May 16, 2021
90c2430
Update .buildpacks
jdauphant May 16, 2021
64ef8d4
Update .buildpacks
jdauphant May 16, 2021
c30877b
Create detect
jdauphant May 16, 2021
67024e4
Update compile
jdauphant May 16, 2021
f8893ff
Update compile
jdauphant May 16, 2021
8048a2d
Update compile
jdauphant May 16, 2021
6b716e6
Update compile
jdauphant May 16, 2021
55ffea7
Update compile
jdauphant May 16, 2021
690d32d
Merge branch 'Scalingo:master' into metabase-with-plugins
jdauphant Jul 16, 2021
8dee709
Update compile
jdauphant Nov 19, 2021
47f19e7
Merge branch 'github.com/betagouv/metabase-scalingo.git/metabase-with…
Frzk Aug 10, 2022
8a1317d
feat: add support for CSV driver plugin
Frzk Aug 10, 2022
cd25b67
fix: restore `.buildpacks` file from master
Frzk Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,29 @@ $ git push scalingo master
The following environment variables are available for you to adjust, depending
on your needs:

| Name | Description | Default value |
| -------------------- | ---------------------------------------------------------------------------------------- | ----------------------------------------------- |
| `BUILDPACK_URL` | URL of the buildpack to use. | https://github.com/Scalingo/multi-buildpack.git |
| `DATABASE_URL` | URL of your database addon. **Only available if you have a database addon provisioned**. | Provided by Scalingo |
| `MAX_METASPACE_SIZE` | Maximum amount of memory allocated to Java Metaspace[^1]. | `512m` (512MB) |
| `BUILDPACK_URL` | |
| --------------: | ----------------------------------------------- |
| Description | URL of the buildpack to use. |
| Required | Yes |
| Default | https://github.com/Scalingo/multi-buildpack.git |

| `DATABASE_URL` | |
| -------------: | --------------------------------------------------------------------------------------- |
| Description | URL of the database addon. **Only available if you have a database addon provisioned.** |
| Required | No |
| Default | Provided by Scalingo. |

| `MAX_METASPACE_SIZE` | |
| -------------------: | --------------------------------------------------------- |
| Description | Maximum amount of memory allocated to Java Metaspace[^1]. |
| Required | No |
| Default | `512m` (512MB) |

| `ENABLE_METABASE_CSV_PLUGIN` | |
| ---------------------------: | --------------------------------------------------------------------------------------- |
| Description | Whether to load the CSV driver plugin for Metabase or not. |
| Required | No |
| Default | `false` - **When defined**, anything but `false`, `FALSE` and `0` is considered `true`. |

Metabase also [supports many environment variables](https://www.metabase.com/docs/latest/operations-guide/environment-variables.html).

Expand Down
35 changes: 35 additions & 0 deletions bin/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/bin/bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're trying to convert this repository to a buildpack. But this repository is not in the chain of buildpack (see .buildpacks file).
Plus wouldn't it be better to backport those changes into the metabase buildpack and not create a new one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I didn't think this would be an issue. But I understand your point, closing for now.


set -eu

metabase_plugin_csv_url="https://github.com/Markenson/csv-metabase-driver/releases/download/%s/csv.metabase-driver.jar"
metabase_plugin_csv_version="v1.3.1"


is_true() {
if [[ "$1" = 0 ]]
then
false
elif [[ -z "$1" ]]
then
false
elif [[ "$1" =~ [Ff][Aa][Ll][Ss][Ee] ]]
then
false
fi
}


metabase_plugins_dir="${1}/plugins"
mkdir -p "${metabase_plugins_dir}"


printf -v mb_plugin_csv_url "${metabase_plugin_csv_url}" "${metabase_plugin_csv_version}"

if is_true "${ENABLE_METABASE_CSV_PLUGIN}"
then
echo -n "- Install CSV plugin : "
cd "${metabase_plugins_dir}"
curl --location --remote-name "${mb_plugin_csv_url}"
echo "Done"
fi
4 changes: 4 additions & 0 deletions bin/detect
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh

echo "Metabase"
exit 0
4 changes: 4 additions & 0 deletions scalingo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
"MAX_METASPACE_SIZE": {
"description": "Control max memory available",
"value": "512m"
},
"ENABLE_METABASE_CSV_PLUGIN": {
"description": "Whether to load the CSV driver plugin or not",
"value": "false"
}
},
"addons": ["postgresql:postgresql-starter-512"]
Expand Down