Small fixes #266
Merged
Small fixes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If exception occurred (timeout to HyperCore cluster), resp was not defined and code crashed. Also, q() cannot be called with kwargs syntax (`exception=ex`). Signed-off-by: Justin Cinkelj <[email protected]>
The https://10.5.11.201 was not yet updated to 9.2.22.212325, upgrade is available for it too. Signed-off-by: Justin Cinkelj <[email protected]>
CI tests were creating VMs with tag Xlab, but without tag CI. Also, remove only VMs older that N days (N=2). Then we can run cleanup in parallel with the tests. Signed-off-by: Justin Cinkelj <[email protected]>
Now we can run cleanup in parallel with SMB import/export tests. Problem could happen near 30/31/1 of month. Signed-off-by: Justin Cinkelj <[email protected]>
justinc1
force-pushed
the
small-fixes
branch
from
94801f5 to
bdd1f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only small fixes. The debug HTTP request logging can be enabled with
SC_DEBUG_LOG_TRAFFIC=1environ variable. The code crashed if request timed out, as we wanted to log HTTP response, but variable was not set.The CI test need to expect 9.2.17.211525 as available update (HyperCore version upgrade).
The cleanup on SMB server is modified to run even if tests fail. The cleanup will remove all files not from current month (before: not from current day). This cloud interfere with tests on first/last day of month, but in practice we should not have a problem as the cleanup will be scheduled before tests.
Similar for DR target cluster, we will remove all VMs older that 2 days. Should not interfere with tests at all.
Here we remove all old replicated VMs with tag "Xlab" (before tag Xlab and CI was needed; but we forgot to include "CI" string in some tests, so VMs were not removed).