Fix title update (#3)

ScaCap · Jul 13, 2021 · 2a7bdec · 2a7bdec
1 parent ba0a04a
commit 2a7bdec
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 9 deletions.
diff --git a/.github/labeler.yml b/.github/labeler.yml
@@ -1,2 +1,2 @@
 '⚠️ danger ⚠️': '.github/labeler.yml'
-'my-test-label': '.github/labeler.yml'
+'my-test-label': '.github/labeler.yml'
diff --git a/dist/index.js b/dist/index.js
@@ -233,14 +233,23 @@ function addLabels(client, prNumber, labels) {
 }
 function updateTitle(client, prNumber, labels, title) {
     return __awaiter(this, void 0, void 0, function* () {
-        const updated = title.endsWith(']')
-            ? title.slice(0, title.lastIndexOf('[')) + ' [' + labels.join(' | ') + ']'
-            : title + ' [' + labels.join(' | ') + ']';
+        let updatedTitle = title;
+        if (labels.length > 0) {
+            if (title.endsWith(']')) {
+                updatedTitle = title.slice(0, title.lastIndexOf(' [')) + ' [' + labels.join(' | ') + ']';
+            }
+            else {
+                updatedTitle = title + ' [' + labels.join(' | ') + ']';
+            }
+        }
+        if (labels.length === 0 && title.endsWith(']')) {
+            updatedTitle = title.slice(0, title.lastIndexOf(' ['));
+        }
         yield client.rest.pulls.update({
             owner: github.context.repo.owner,
             repo: github.context.repo.repo,
             pull_number: prNumber,
-            title: updated
+            title: updatedTitle
         });
     });
 }

diff --git a/src/labeler.ts b/src/labeler.ts
@@ -253,14 +253,24 @@ async function updateTitle(
   labels: string[],
   title: string
 ) {
-  const updated = title.endsWith(']') 
-    ? title.slice(0, title.lastIndexOf('[')) + ' [' + labels.join(' | ') + ']'
-    : title + ' [' + labels.join(' | ') + ']';
+  let updatedTitle = title;
+  if (labels.length > 0) {
+    if (title.endsWith(']')){
+      updatedTitle = title.slice(0, title.lastIndexOf(' [')) + ' [' + labels.join(' | ') + ']';
+    } else {
+      updatedTitle = title + ' [' + labels.join(' | ') + ']';
+    }
+  }
+
+  if (labels.length === 0 && title.endsWith(']')) {
+    updatedTitle = title.slice(0, title.lastIndexOf(' ['));
+  }
+
   await client.rest.pulls.update({
     owner: github.context.repo.owner,
     repo: github.context.repo.repo,
     pull_number: prNumber,
-    title: updated
+    title: updatedTitle
   });
 }