Skip to content

Commit

Permalink
Fixed an issue that was happening when trying to Auto-Assign Loot fro…
Browse files Browse the repository at this point in the history
…m the Solver when there were Greed slots for the week
  • Loading branch information
freyamade committed Aug 14, 2024
1 parent 6a56367 commit e3df1b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 2 additions & 4 deletions frontend/src/components/modals/changelog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@
</div>
<div class="card-content content">
<h2 class="has-text-primary subtitle">{{ version }}</h2>
<div class="divider"><i class="material-icons icon">expand_more</i> Loot Solver Update <i class="material-icons icon">expand_more</i></div>
<p>Discovered a major issue with the Loot Solver algorithm being inefficient due to it being super naive.</p>
<p>This release improves the algorithm to be more true to the "top N people get items every week".</p>
<p>A whole writeup of the methodology is available <a href="https://github.com/orgs/SavageAim/discussions/1" target="_blank">here</a>, in case anyone wants to have a read!</p>
<div class="divider"><i class="material-icons icon">expand_more</i> Fixes and Improvements <i class="material-icons icon">expand_more</i></div>
<p>Fixed an issue that was happening when trying to Auto-Assign Loot from the Solver when there were Greed slots for the week.</p>
</div>
</div>
</template>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/team/loot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export default class TeamLoot extends TeamViewMixin {
// Turn data object into a map of item: PFCM
const chosenMembers: { [item: string]: PerFightChosenMember } = {}
Object.entries(data).forEach(([item, memberId]) => {
if (item !== 'token') {
if (item !== 'token' && memberId !== null) {
const member = this.getTeamMember(memberId)
const itemsObtained = this.loot.received[member.name]?.need || 0
chosenMembers[item] = {
Expand Down

0 comments on commit e3df1b9

Please sign in to comment.