Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added top-song working in Home page music-player #479

Conversation

The-Phoenics
Copy link
Contributor

@The-Phoenics The-Phoenics commented Jul 11, 2024

Description

Refactored topSongs, setTopSongs state into higher component (Home), the MusicPlayer now loads with the topSong when home page loads.

Related Issues

Screenshots (if applicable)

music-player

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spring-music-player ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 0:04am

Copy link

vercel bot commented Jul 11, 2024

@The-Phoenics is attempting to deploy a commit to the satyam1923's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @The-Phoenics! 🎉 Thank you for submitting your first pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We'd also like to invite you to our Discord server! Join us here.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Satyam1923
Copy link
Owner

@The-Phoenics what about firestore?

@Satyam1923 Satyam1923 added bug Something isn't working enhancement New feature or request gssoc labels Jul 11, 2024
@The-Phoenics
Copy link
Contributor Author

@Satyam1923 How can I access project's firebase firestore?

@The-Phoenics
Copy link
Contributor Author

Hey @saurabhsingh720
Can you merge this PR?

Copy link

This PR has been automatically closed due to inactivity from the owner for 15 days.

@github-actions github-actions bot added the Stale label Aug 14, 2024
@github-actions github-actions bot closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request gssoc Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Home page music player doesn't function home page loads
2 participants