[6.16.z] better logging of fam failures #17001
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #16967
Problem Statement
The output of FAM tests is mangled due to how pytest tries to print the big
result
object.There are no linebreaks and it's super hard to find the failure.
Additionally the double assert is pointless, as it asserts twice the same thing: the result is successful.
Solution
Stop asserting
PASSED
in stdout (additionally saves the case where there is the stringPASSED
in the output for some reason, but the test actually failed).Pass a custom error output to the
status == 0
assertion, including stdout, stderr and the status code.Related Issues