-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clean button locator in PF4 search. #965
Fix clean button locator in PF4 search. #965
Conversation
As it was, we were getting an error when searching for the element, getting False for is_displayed. Consequently, the clear button was not clicked and a generic browser clear was called instead. The text disappeared for a bit and then it got re-filled to the search field. It caused failures in tests such as tests/foreman/ui/test_dashboard.py::test_positive_task_status Changing type and locator fixes the issue.
trigger: test-robottelo |
trigger: test-robottelo |
Cause of failure unrelated, it also fails in snap automation:
Rerunning without the offending test. |
trigger: test-robottelo |
The failures in PRT don't seem related. They only fail in master, not 6.14.z, and the same failure happens in master when I revert my commit. I wanted to use PRT to check whether I cause regression or not but in the end, I ran on 6.14.z branch (with this commit cherrypicked) locally:
There are many navigation related issues in Stream so I think this is merge worthy as it is. Alternatively, we can only merge into 6.14.z (that means future work). |
Do we need it in older satellite versions as well @lhellebr? |
In 6.13.z branch, the locator is |
As it was, we were getting an error when searching for the element, getting False for is_displayed. Consequently, the clear button was not clicked and a generic browser clear was called instead. The text disappeared for a bit and then it got re-filled to the search field. It caused failures in tests such as tests/foreman/ui/test_dashboard.py::test_positive_task_status Changing type and locator fixes the issue. (cherry picked from commit 80b7eb9)
As it was, we were getting an error when searching for the element, getting False for is_displayed. Consequently, the clear button was not clicked and a generic browser clear was called instead. The text disappeared for a bit and then it got re-filled to the search field. It caused failures in tests such as tests/foreman/ui/test_dashboard.py::test_positive_task_status Changing type and locator fixes the issue. (cherry picked from commit 80b7eb9) Co-authored-by: Lukáš Hellebrandt <[email protected]>
As it was, we were getting an error when searching for the element, getting False for is_displayed. Consequently, the clear button was not clicked and a generic browser clear was called instead. The text disappeared for a bit and then it got re-filled to the search field.
It caused failures in tests such as
tests/foreman/ui/test_dashboard.py::test_positive_task_status
Changing type and locator fixes the issue.