Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split group and direct conversation into their own struct #648

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dariusc93
Copy link
Contributor

What this PR does πŸ“–

  • split group and direct conversations into their own structure.
  • remove redundant functions

Which issue(s) this PR fixes πŸ”¨

Special notes for reviewers πŸ—’οΈ

  • this would be considered a breaking change

Additional comments 🎀

  • this change would prep for merging common logic between direct, group and communities to reduce codebase.
  • later change may split the task into up so one would handle direct conversations and groups to reduce logic.
    • this might still result in duplicated code, although we could process the common events in a single function with the conversation specific events being pushed into its respected function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant