Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove shuttle behaviour and send requests directly #641

Merged
merged 40 commits into from
Dec 10, 2024

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Dec 4, 2024

What this PR does 📖

  • remove the behaviour and send messages and request directly to shuttle, awaiting a response.
  • add additional options to shuttle cli to configure wss certs and add external addresses
  • remove redundant structs and traits

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

  • previously, we would have the protocol written in a low level state utilizing the request-response from libp2p, however due to the nature of the protocol and how we had to implement it, it created more complexity. This change allow us to send requests directly to the peer (in this case, a shuttle node) without the burden of maintaining the low level state and implementing communication via channels to the behaviour. Additionally, this change allow us to reduce the code base and simplify logic.
  • messaging side will be redone in a separate PR to make it more seamless
  • the protocol may change again but this initial change make it easier to switch and allows for backward compatibility if the change does happen.

@dariusc93 dariusc93 added the blocked Blocked by another feature, request or issue. label Dec 4, 2024
@dariusc93 dariusc93 self-assigned this Dec 4, 2024
@dariusc93 dariusc93 changed the title refactor: use shuttle behaviour and send requests directly refactor: remove shuttle behaviour and send requests directly Dec 4, 2024
@dariusc93 dariusc93 removed the blocked Blocked by another feature, request or issue. label Dec 8, 2024
@dariusc93 dariusc93 marked this pull request as ready for review December 8, 2024 06:40
@dariusc93 dariusc93 added the blocked Blocked by another feature, request or issue. label Dec 8, 2024
@dariusc93 dariusc93 removed the blocked Blocked by another feature, request or issue. label Dec 9, 2024
@dariusc93 dariusc93 merged commit 00d4b78 into main Dec 10, 2024
3 checks passed
@dariusc93 dariusc93 deleted the refactor/shuttle-direct-request-response branch December 10, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant