refactor: Use keypair internally within warp-ipfs #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
force-pushed
the
refactor/keypair-internal
branch
from
960b6c9 to
14c5803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Keypairinternally instead ofDIDfor key exchange and signingWhich issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤
DIDand replacing it for something more suited and friendlier. This PR first replaces where we are performing signing, key exchanges (for encrypting and decrypting)., etc (though we still convert it back to a keypair variant of DID for key exchange, but the next change will be to strip that out internally).