-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use MessageDocument directly and use document variants #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would send a
Message
, which would be encrypted based on the shared for direct messaging or #171 for group messaging due to originally sending this object directly prior to previous refactoring, however this begin to appear redundant as we had additional metadata onMessageDocument
that mimics what was stored onMessage
(eg pinning indication, creation/modified dates, etc), while also storing the encrypted variant on this document. Furthermore, because we will be having additional metadata such as attachments, reactions, etc., onMessageDocument
, it only made sense to use it directly instead of storing andMessage
directly.What this PR does 📖
MessageDocument
directly when sending or referring to the internal message, encrypting the message lines itself rather thanMessage
.MessageDocument
in a reference list instead of a set with each list containing a max of 500 messages before descending into a new list for the next set.MessageDocument
intoMessage
, allowing us to resolve via bitswap or some other content discovery and fetch protocol when walking its dag.MessageDocument
on the recipient end would contain the same signature when encrypting.MessageDocument
, removingMessage::signature
(this field was used internally and been planned to have removed)Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤
Message
being encrypted. This relates to Shard message list and messages in a conversation #125.