Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raygun: Set a restriction to reactions #415

Open
dariusc93 opened this issue Jan 7, 2024 · 0 comments
Open

raygun: Set a restriction to reactions #415

dariusc93 opened this issue Jan 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request improvement Improve on existing feature P-Normal Normal Priority question Further information is requested

Comments

@dariusc93
Copy link
Contributor

dariusc93 commented Jan 7, 2024

In the current implementations, reactions are unbound in itself, allowing for any length of text for the reactions, however leaving it unbound internally can lead to increase in memory if a larger reaction is set. Adding a check to restrict the length would help, but the question would be to what specific length since some implementations may use unicode, while others might use shortcode/cldr and translate that on the frontend.

For the time being, I believe, 128 characters will work, and what could be done is that we can have this adjustable in the configuration on a frontend-by-frontend basis, however restricting it so that it will only receive reaction events when those lengths is less than or equal to the configured amount, while anything more it would get rejected.

@dariusc93 dariusc93 added enhancement New feature or request question Further information is requested improvement Improve on existing feature labels Jan 7, 2024
@dariusc93 dariusc93 self-assigned this Jan 7, 2024
@dariusc93 dariusc93 added the P-Normal Normal Priority label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement Improve on existing feature P-Normal Normal Priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant