fix: filter out and skip message if empty within attachment (#646)

Satellite-im · Dec 13, 2024 · fdb96da · fdb96da
1 parent 5513ff2
commit fdb96da
Showing 1 changed file with 2 additions and 16 deletions.
diff --git a/extensions/warp-ipfs/src/store/message/attachment.rs b/extensions/warp-ipfs/src/store/message/attachment.rs
@@ -84,29 +84,15 @@ impl AttachmentStream {
     }
 
     pub fn set_lines(mut self, lines: Vec<String>) -> Result<Self, Error> {
-        if lines.is_empty() {
-            return Ok(self);
-        }
-
         let lines_value_length: usize = lines
             .iter()
             .filter(|s| !s.is_empty())
             .map(|s| s.trim())
             .map(|s| s.chars().count())
             .sum();
 
-        if lines_value_length < MIN_MESSAGE_SIZE {
-            tracing::error!(
-                current_size = lines_value_length,
-                min = MIN_MESSAGE_SIZE,
-                "length of message is invalid"
-            );
-            return Err(Error::InvalidLength {
-                context: "message".into(),
-                current: lines_value_length,
-                minimum: None,
-                maximum: Some(MIN_MESSAGE_SIZE),
-            });
+        if lines.is_empty() || lines_value_length < MIN_MESSAGE_SIZE {
+            return Ok(self);
         }
 
         if lines_value_length > MAX_MESSAGE_SIZE {