Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): Fix back button on android #965

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix(Android): Fix back button on android #965

merged 4 commits into from
Dec 31, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Dec 21, 2024 •
edited
Loading

What this PR does 📖

  • Fix back button on android
  • If user is on the last level of navigation, back button will exit the app
  • If sidebar is closed, back button will open sidebar first

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Dec 21, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot added Failed Automated Test Failed Automated Tests CI and removed Failed Automated Test Failed Automated Tests CI labels Dec 30, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Dec 31, 2024
@stavares843 stavares843 merged commit 57587f1 into dev Dec 31, 2024
11 checks passed
@stavares843 stavares843 deleted the fix-back-button-on-android branch December 31, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@lgmarchi lgmarchi

Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Android): Using back button on nav bar will exit user out of app
3 participants
@lgmarchi @stavares843 @phillsatellite