Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): fix typing indicator #961

Merged
merged 7 commits into from
Dec 31, 2024
Merged

fix(chat): fix typing indicator #961

merged 7 commits into from
Dec 31, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Fixes typing indicator not resetting

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@lgmarchi lgmarchi added 🫡 Dev Approved Review Dev reviewed the code and approved it. and removed Missing dev review Two dev reviews are required on PR labels Dec 20, 2024
@phillsatellite
Copy link
Contributor

@Flemmli97 This is working a lot better but there is a bug that Ive noticed that I was not able to replicate on the dev branch

It looks like when a user has more than 1 chat in the sidebar, when a friend types they're typing indicator will appear on all the chats in the sidebar

How to replicate:

  • Make sure you have more than 1 chat in the sidebar and have one of your friends type to you

This branch:
https://github.com/user-attachments/assets/0f54e90b-7bfd-4ac2-9d4a-011812e5c1a0

Dev branch:
https://github.com/user-attachments/assets/42c698eb-ad15-4ff1-b5e5-567c42d1b6dd

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed being tested labels Dec 28, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Dec 30, 2024
@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 30, 2024
@Flemmli97
Copy link
Contributor Author

i also added a typing indicator to group chats (multiple profile pics). it doesnt fit correctly though so should i remove that again?

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Dec 30, 2024
@phillsatellite
Copy link
Contributor

i also added a typing indicator to group chats (multiple profile pics). it doesnt fit correctly though so should i remove that again?

Yeah I guess for now we can just remove

@stavares843 stavares843 added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 30, 2024
@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 31, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Dec 31, 2024
@phillsatellite phillsatellite merged commit acce6b0 into dev Dec 31, 2024
11 checks passed
@phillsatellite phillsatellite deleted the typing-indicator-fix branch December 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@lgmarchi lgmarchi lgmarchi approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
🫡 Dev Approved Review Dev reviewed the code and approved it. QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Chat): Typing indicator persist when user is not typing
4 participants
@Flemmli97 @phillsatellite @stavares843 @lgmarchi