Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share): add share functionality for backup seed phrase on mobile #942

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Dec 13, 2024

What this PR does 📖

  • add share functionality for backup seed phrase on mobile

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Dec 13, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Dec 13, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Dec 13, 2024
@lgmarchi lgmarchi removed the Missing fixing conflict Needs to fix conflicts label Dec 13, 2024
@phillsatellite
Copy link
Contributor

Sent Lucas a dm on iOS it has the option to add directly to files. Android doesnt seem to have that. Figured it was an OS thing but Lucas said there might be a way we could get that on Android too. Either way pr is good by me

image

image

@dariusc93
Copy link
Contributor

Could you explain the purpose of sharing the phrase or what use case that may serve? I would imagine just downloading it as a form of backup would be enough to be secured as it is stored locally, but if its to be shared through any other means, it wouldnt be secured since the phrase would be in plain text and exposed, especially if one wants to upload it to say google drive, iCloud, etc.

@dariusc93 dariusc93 added the question Further information is requested label Dec 14, 2024
@lgmarchi
Copy link
Collaborator Author

Could you explain the purpose of sharing the phrase or what use case that may serve? I would imagine just downloading it as a form of backup would be enough to be secured as it is stored locally, but if its to be shared through any other means, it wouldnt be secured since the phrase would be in plain text and exposed, especially if one wants to upload it to say google drive, iCloud, etc.

Share functionality is exactly people decide what they want to do with seed phrase, save on documents, upload in somewhere, or other thing.

If we just put download, it will just download seed phrase in documents of phone, and probably person will forget there is a seed phrase there

@stavares843 stavares843 merged commit 047471f into dev Dec 17, 2024
7 checks passed
@stavares843 stavares843 deleted the fix-download-seed-phrase-on-mobile branch December 17, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Mobile): User cannot download Seed Phrases
4 participants