Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat): fix chat in nav bar #929

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(chat): fix chat in nav bar #929

merged 1 commit into from
Dec 9, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Fixes the problem when clicking on chat button in navigation bar a paste dropdown pops up. This is caused by a clipboard access (which is used to copy image content to clipboard). I rewrote it to a lazy approach so the first time a user tries to copy an image and the user denies the permission the copy image button will be not shown anymore

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@lgmarchi lgmarchi added the 🫡 Dev Approved Review Dev reviewed the code and approved it. label Dec 9, 2024
@phillsatellite phillsatellite added being tested and removed Missing dev review Two dev reviews are required on PR labels Dec 9, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Dec 9, 2024 •
edited
Loading

Hey @Flemmli97 I noticed when you switch to chat in the navBar whatever chat you are on will open a little bit. Instead of just showing the sidebar

It worked fine on MacOS and Android though

Screen.Recording.2024-12-09.at.12.45.51.PM.mov

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed being tested labels Dec 9, 2024
@Flemmli97
Copy link
Contributor Author

Hey @Flemmli97 I noticed when you switch to chat in the navBar whatever chat you are on will open a little bit. Instead of just showing the sidebar

It worked fine on MacOS and Android though

Screen.Recording.2024-12-09.at.12.45.51.PM.mov

thats this #694. unrelated

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 9, 2024
@phillsatellite phillsatellite added Ready to Merge This PR is tested and ready for merge and removed being tested 🫡 Dev Approved Review Dev reviewed the code and approved it. labels Dec 9, 2024
@phillsatellite phillsatellite merged commit 6eb4ec1 into dev Dec 9, 2024
13 checks passed
@phillsatellite phillsatellite deleted the chat_button_fix branch December 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@lgmarchi lgmarchi lgmarchi approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
Ready to Merge This PR is tested and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(iOS): App freezes momentarily when user taps chat
4 participants
@Flemmli97 @phillsatellite @stavares843 @lgmarchi