feat(iOS): Paint safe areas on iOS mobile #928
Conversation
…eme using swift code
…Plugin with updated methods for color handling
github-actions
bot
added
the
Missing dev review
|
Download the app installers for this pull request: |
| call.reject("No active window found") | ||
| } | ||
| } else { | ||
| // For iOS 12 and earlier |
There was a problem hiding this comment.
we don't support 12 and earlier, our version minimum atm is 16 - latest iOS is 18
There was a problem hiding this comment.
I did this condition based on code made for cut Safe Areas. So remove this condition from there as well?
There was a problem hiding this comment.
we can keep it if you want, just saying that since we only support iOS 16 and above the code is not being used
There was a problem hiding this comment.
I think you are correct, if both are dead code, they should be removed to not have unnecessary code.
And the condition is using 13.0, we can increase this number to 16 as well.
android/app/capacitor.build.gradle
Outdated
| @@ -16,6 +16,8 @@ dependencies { | |||
| implementation project(':capacitor-keyboard') | |||
| implementation project(':capacitor-screen-orientation') | |||
| implementation project(':capacitor-splash-screen') | |||
| implementation project(':capacitor-status-bar') | |||
|
|
|||
phillsatellite
added
question
|
Added question for Sara's comment above |
lgmarchi
added
⌨️ Ready for Test
phillsatellite
added
being tested
and removed
⌨️ Ready for Test
phillsatellite
added
QA Approved
|
Sent Lucas a message I tested again after Lucas fixed the conflicts but I'm getting an error when doing npm run build that I'm not able to replicate on dev branch
|
phillsatellite
added
the
QA Requested Changes
phillsatellite
removed
the
QA Requested Changes
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤