Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Navigation): Improve navigation using bottom nav bar on mobile #926

Merged
merged 22 commits into from
Dec 13, 2024
Merged

fix(Navigation): Improve navigation using bottom nav bar on mobile #926

merged 22 commits into from
Dec 13, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Dec 6, 2024

What this PR does 📖

  • Improve navigation using bottom nav bar on mobile

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Dec 6, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@luisecm
Copy link
Contributor

luisecm commented Dec 6, 2024

@lgmarchi Hey Lucas, automation tests caught one bug on this branch:

  1. Open in mobile view
  2. Click on create group chat
  3. Create group modal is not visible until you swipe to the right (like in the video from the example):
Grabacion.de.pantalla.2024-12-06.a.la.s.2.21.38.p.m.mov

Currently in dev, if you are on mobile view and then click on Create group, you can see the create group modal without having to swipe

@lgmarchi lgmarchi added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 6, 2024
@luisecm luisecm mentioned this pull request Dec 6, 2024
Merged
@lgmarchi
Copy link
Collaborator Author

lgmarchi commented Dec 6, 2024

@lgmarchi Hey Lucas, automation tests caught one bug on this branch:

  1. Open in mobile view
  2. Click on create group chat
  3. Create group modal is not visible until you swipe to the right (like in the video from the example):

Grabacion.de.pantalla.2024-12-06.a.la.s.2.21.38.p.m.mov
Currently in dev, if you are on mobile view and then click on Create group, you can see the create group modal without having to swipe

@lgmarchi Hey Lucas, automation tests caught one bug on this branch:

  1. Open in mobile view
  2. Click on create group chat
  3. Create group modal is not visible until you swipe to the right (like in the video from the example):

Grabacion.de.pantalla.2024-12-06.a.la.s.2.21.38.p.m.mov
Currently in dev, if you are on mobile view and then click on Create group, you can see the create group modal without having to swipe

Fixed.

@lgmarchi lgmarchi removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 6, 2024
@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Dec 9, 2024
@stavares843
Copy link
Member

@lgmarchi could you add which PR is this one waiting for please, for us to know when merging

@lgmarchi
Copy link
Collaborator Author

Waiting PR #925

@lgmarchi lgmarchi added the ⌨️ Ready for Test PR is ready for test label Dec 10, 2024
@stavares843 stavares843 added being tested and removed ⌨️ Ready for Test PR is ready for test labels Dec 10, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Dec 10, 2024 •
edited
Loading

Noticed some issues. These issues are able to be replicated on both Android & iOS. Both were new accounts on brand new builds

  • navbar appears through the entire Account Creation process
    image

-navbar will persist while keyboard is open and overlap the cancel/continue buttons
image

  • After you enter into a chat and you open the sidebar the navbar will disappear and there is no way for the user to bring it back
    image

  • Within Settings any page that user is able to scroll in, the navbar will overlap whatever content is at the end of the page

About
image

Audio
image

Gamepad
image

Profile
image

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed being tested labels Dec 10, 2024
@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Dec 12, 2024
@phillsatellite phillsatellite added being tested Missing dev review Two dev reviews are required on PR and removed Missing dev review Two dev reviews are required on PR ⌨️ Ready for Test PR is ready for test labels Dec 12, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed being tested labels Dec 12, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Dec 12, 2024
@phillsatellite phillsatellite removed the QA Approved PR has been tested by QA Team label Dec 12, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed Missing fixing conflict Needs to fix conflicts labels Dec 12, 2024
@lgmarchi lgmarchi added 🫡 Dev Approved Review Dev reviewed the code and approved it. and removed Missing dev review Two dev reviews are required on PR labels Dec 13, 2024
@stavares843 stavares843 merged commit 2ae2301 into dev Dec 13, 2024
7 checks passed
@stavares843 stavares843 deleted the fix-bottom-nav-bar-on-mobile branch December 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@ashneverdawn ashneverdawn ashneverdawn approved these changes

Assignees

@lgmarchi lgmarchi

Labels
🫡 Dev Approved Review Dev reviewed the code and approved it. QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgmarchi @luisecm @stavares843 @phillsatellite @ashneverdawn