Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Keyboard): Fix keyboard on mobile #922

Merged
merged 20 commits into from
Dec 12, 2024
Merged

fix(Keyboard): Fix keyboard on mobile #922

merged 20 commits into from
Dec 12, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Dec 5, 2024 •
edited
Loading

What this PR does 📖

  • Fix keyboard on chats for iOS, chatbar is going up when keyboard is opened (iOS only)
  • Fix bottomNavBar appearing when keyboard is opened, now if keyboard is opened, bottomNavBar will be hided (iOS and Android)
  • Fix screen on create account and profile for iOS when open keyboard to not hide inputs (iOS only)

Note

Maybe there is a little glitch when you go to chats from friends page, margin between chatbar and keyboard is big, but it just happened first time, if closes keyboard and open again, margin is correct.

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Dec 5, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Download the app installers for this pull request:

@phillsatellite phillsatellite added the 📄 Draft PR is not ready yet label Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Dec 6, 2024
@lgmarchi lgmarchi removed the Missing fixing conflict Needs to fix conflicts label Dec 6, 2024
@lgmarchi lgmarchi marked this pull request as ready for review December 6, 2024 19:15
@lgmarchi lgmarchi removed the 📄 Draft PR is not ready yet label Dec 6, 2024
@phillsatellite
Copy link
Contributor

Hey Lucas I noticed a few issues while testing.

Issues:

  • Switching to a new chat in the sidebar keyboard will overlap the chatbar

  • Going to Friends then tapping chat, keyboard will overlap the chatbar

Screen.Recording.2024-12-09.at.5.53.37.PM.mov

Also I am thinking we should probably have the keyboard stay open after a user sends a message. That way they dont have to keep re-opening it

Screen.Recording.2024-12-09.at.5.55.22.PM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 9, 2024
@lgmarchi
Copy link
Collaborator Author

Hey Lucas I noticed a few issues while testing.

Issues:

  • Switching to a new chat in the sidebar keyboard will overlap the chatbar
  • Going to Friends then tapping chat, keyboard will overlap the chatbar

Screen.Recording.2024-12-09.at.5.53.37.PM.mov
Also I am thinking we should probably have the keyboard stay open after a user sends a message. That way they dont have to keep re-opening it

Screen.Recording.2024-12-09.at.5.55.22.PM.mov

Good points, I will take a look.

@lgmarchi
Copy link
Collaborator Author

Now, when we enter in chats, it will build without keyboard
If user click on input, keyboard will be opened
And after send message, keyboard will keep opened

@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Dec 10, 2024
@phillsatellite phillsatellite added being tested and removed ⌨️ Ready for Test PR is ready for test labels Dec 10, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Dec 10, 2024 •
edited
Loading

Sent Lucas a DM, it looks like everything is fixed except for when the user switches to another chat via the sidebar on both iOS & Android. Other than that last issue all is good!

Screen.Recording.2024-12-10.at.5.07.58.PM.mov

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed being tested labels Dec 10, 2024
@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Dec 12, 2024
@stavares843 stavares843 added being tested and removed ⌨️ Ready for Test PR is ready for test labels Dec 12, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed being tested labels Dec 12, 2024
@lgmarchi lgmarchi added 🫡 Dev Approved Review Dev reviewed the code and approved it. and removed Missing dev review Two dev reviews are required on PR labels Dec 12, 2024
@phillsatellite phillsatellite merged commit e2435ec into dev Dec 12, 2024
11 checks passed
@phillsatellite phillsatellite deleted the fix-keyboard-on-mobile branch December 12, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@ashneverdawn ashneverdawn ashneverdawn approved these changes

Assignees

@lgmarchi lgmarchi

Labels
🫡 Dev Approved Review Dev reviewed the code and approved it. QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
4 participants
@lgmarchi @phillsatellite @ashneverdawn @stavares843