Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Update InstallBanner to hide on mobile devices #903

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Dec 2, 2024

What this PR does 📖

This pull request includes a small but significant change to the InstallBanner component in the src/lib/components/ui/InstallBanner.svelte file. The change involves adding a new function to detect mobile devices and updating the logic for showing the install banner.

Changes to InstallBanner component:

  • Added isMobile function to detect mobile user agents.
  • Updated showBanner logic to include isMobile function in the conditions for hiding the banner.
  • isCapacitor was causing the error, because we are using some capacitor libs for web as well

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Dec 2, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Dec 2, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@stavares843 stavares843 merged commit a086f60 into dev Dec 2, 2024
18 of 25 checks passed
@stavares843 stavares843 deleted the fix-banner branch December 2, 2024 21:26
stavares843 added a commit that referenced this pull request Dec 2, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Dec 2, 2024

Hey @lgmarchi We reverted this because @luis found a bug where the banner was not appearing in mobile viewport

Steps to reproduce were
-go to chrome
-mobile viewport
-refresh
-banner doesnt appear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants