Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Mobile): Fix copy did on friends page in mobile #897

Merged
merged 9 commits into from
Dec 3, 2024
Merged

fix(Mobile): Fix copy did on friends page in mobile #897

merged 9 commits into from
Dec 3, 2024

Conversation

lgmarchi
Copy link
Collaborator

What this PR does 📖

  • With old code, copy DID was not working properly on mobile, so now is guaranteed DID string is on clipboard

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Nov 28, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 28, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 28, 2024
@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Nov 29, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 30, 2024
@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Dec 1, 2024
stavares843
stavares843 requested changes Dec 2, 2024
View reviewed changes
ios/App/Podfile.lock Outdated Show resolved Hide resolved
@stavares843 stavares843 added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Dec 2, 2024
@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Dec 3, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Dec 3, 2024
@stavares843 stavares843 removed Missing fixing conflict Needs to fix conflicts QA Requested Changes Changes need to be addressed, something is not working as expected. labels Dec 3, 2024
@phillsatellite
Copy link
Contributor

Never experienced this bug on dev/mobile but still works great when testing so approved! 🍏

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Dec 3, 2024
@stavares843 stavares843 merged commit fa3eba2 into dev Dec 3, 2024
11 checks passed
@stavares843 stavares843 deleted the mobile-fix-copy-did-on-friends-page branch December 3, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@lgmarchi lgmarchi

Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgmarchi @phillsatellite @stavares843