fix(Mobile): Fix context menu on storage with long press #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storage-on-mobile
…r mobile on context menu
github-actions
bot
added
the
Missing dev review
|
Download the app installers for this pull request: |
phillsatellite
approved these changes
Dec 3, 2024
ashneverdawn
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
This pull request includes several changes to improve the functionality and user experience of the context menu and file upload components. The most important changes include adding touch support for the context menu, refining the position calculation logic, and simplifying the file upload process.
Enhancements to context menu:
src/lib/components/ui/ContextMenu.svelte: Added touch support by implementinghandleTouchStartandhandleTouchEndfunctions, and updated theopenContextandcalculatePosfunctions to handle both mouse and touch events. [1] [2] [3]src/lib/components/ui/ContextMenu.svelte: Added event listeners for touch events inonMountand removed them inonDestroy.Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤