-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CallPopUp): Enable call pop up when user is out of active call chat #855
Conversation
…e status indicators
…d enhance user visibility
…tatus in video preview
Download the app installers for this pull request: |
@stavares843 and @phillsatellite I think it has a problem yet, when we test with user that didn't do the call. |
…ideo preview when no users joined the call yet
… for better visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug
Gravacao.do.ecra.2024-11-19.as.22.15.52.mov
then both @phillsatellite and i had the following bug
290390209.mov
also no image when i activate video but worked for @phillsatellite - works on dev
browser - chrome
Very interesting, I will do more tests and try to improve this code. |
…t-showing' into Bug/SAT-854/call-video-popout-not-showing
…d VideoPreview components
…haring and video enabled states
…-popout-not-showing
…and integrate it into CallScreen and VideoPreview
I did a commit for it. |
What this PR does 📖
This pull request includes significant updates to the
VideoPreview
component in the calling module. The changes involve enhancing the video preview functionality, improving the user interface, and fixing the visibility toggle for the call screen.Enhancements to
VideoPreview
functionality:src/lib/components/calling/VideoPreview.svelte
: Replaced theshow
variable withshowVideoPreview
to control the visibility of the video preview, and added logic to sort and filter users based on their audio status.src/lib/components/calling/VideoPreview.svelte
: Implemented a newattachStream
function to handle the attachment of video streams to video elements.User interface improvements:
src/lib/components/calling/VideoPreview.svelte
: Updated the video preview container to use a grid layout for displaying multiple video streams, and added styles to improve the appearance and layout of video elements. [1] [2]Visibility toggle fix:
src/lib/media/Voice.ts
: Moved thecallScreenVisible.set(false)
statement to ensure the call screen visibility is correctly toggled when leaving a call. [1] [2]Re-enabling the
VideoPreview
component:src/routes/+layout.svelte
: Re-enabled theVideoPreview
component in the layout by removing the comment that was disabling it.Special notes for QAs 🧪
It will just show 3 users in Video Preview, even if call has 10 users on it. But, if last user in call, start to speak, he will be changed to the first place in the list, and will appear on Video Preview.
Video
Screen.Recording.2024-11-14.at.16.25.54.mov
When user leave a call, should update video preview immediately.
Video
Screen.Recording.2024-11-14.at.16.44.05.mov
It works with video enabled too.
Image
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤