Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CallPopUp): Enable call pop up when user is out of active call chat #855

Merged
merged 18 commits into from
Nov 22, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Nov 14, 2024

What this PR does 📖

This pull request includes significant updates to the VideoPreview component in the calling module. The changes involve enhancing the video preview functionality, improving the user interface, and fixing the visibility toggle for the call screen.

Enhancements to VideoPreview functionality:

User interface improvements:

Visibility toggle fix:

  • src/lib/media/Voice.ts: Moved the callScreenVisible.set(false) statement to ensure the call screen visibility is correctly toggled when leaving a call. [1] [2]

Re-enabling the VideoPreview component:

  • src/routes/+layout.svelte: Re-enabled the VideoPreview component in the layout by removing the comment that was disabling it.

Special notes for QAs 🧪

  • It will just show 3 users in Video Preview, even if call has 10 users on it. But, if last user in call, start to speak, he will be changed to the first place in the list, and will appear on Video Preview.

    Video

    Screen.Recording.2024-11-14.at.16.25.54.mov

  • When user leave a call, should update video preview immediately.

    Video

    Screen.Recording.2024-11-14.at.16.44.05.mov

  • It works with video enabled too.

    Image

    image

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Nov 14, 2024
@lgmarchi lgmarchi linked an issue Nov 14, 2024 that may be closed by this pull request
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 14, 2024
@lgmarchi
Copy link
Collaborator Author

@stavares843 and @phillsatellite I think it has a problem yet, when we test with user that didn't do the call.

@lgmarchi lgmarchi added the 📄 Draft PR is not ready yet label Nov 15, 2024
@lgmarchi
Copy link
Collaborator Author

  • Add feedback when waiting other users to join
image
  • Now showing quantity of users active in call
image

@lgmarchi lgmarchi removed the 📄 Draft PR is not ready yet label Nov 16, 2024
@Satellite-im Satellite-im deleted a comment from github-actions bot Nov 18, 2024
Copy link

github-actions bot commented Nov 19, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Nov 19, 2024
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug

Gravacao.do.ecra.2024-11-19.as.22.15.52.mov

then both @phillsatellite and i had the following bug

290390209.mov

also no image when i activate video but worked for @phillsatellite - works on dev

image

browser - chrome

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 20, 2024
@lgmarchi
Copy link
Collaborator Author

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug

Gravacao.do.ecra.2024-11-19.as.22.15.52.mov
then both @phillsatellite and i had the following bug

290390209.mov
also no image when i activate video but worked for @phillsatellite - works on dev

image

browser - chrome

Very interesting, I will do more tests and try to improve this code.

@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Nov 22, 2024
@lgmarchi
Copy link
Collaborator Author

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug

Gravacao.do.ecra.2024-11-19.as.22.15.52.mov
then both @phillsatellite and i had the following bug

290390209.mov
also no image when i activate video but worked for @phillsatellite - works on dev

image

browser - chrome

I did a commit for it.

@stavares843 stavares843 added being tested and removed ⌨️ Ready for Test PR is ready for test labels Nov 22, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed being tested labels Nov 22, 2024
@stavares843 stavares843 merged commit b6ee5ce into dev Nov 22, 2024
11 checks passed
@stavares843 stavares843 deleted the Bug/SAT-854/call-video-popout-not-showing branch November 22, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Calling): PopOut viewer is missing
4 participants