fix(calling): refactor code to avoid getTime from a null variable #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing dev review
|
Download the app installers for this pull request: |
phillsatellite
approved these changes
Nov 13, 2024
ashneverdawn
approved these changes
Nov 14, 2024
stavares843
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
This pull request includes a minor change to the
CallScreen.sveltefile to improve the handling of thetimeCallStartedvariable. The change ensures that the variable is checked fornullbefore being used.src/lib/components/calling/CallScreen.svelte: Modified the code to assign$timeCallStartedto a local variabletimeCallStartedand added a null check before using it.Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤