Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layout): clean up code and improve event handling in layout components #851

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

lgmarchi
Copy link
Collaborator

What this PR does 📖

1. Remove unnecessary code and avoid boring messages on console:

Code readability improvements:

Initialization logic:

Debugging and logging:

Before After
image image

2. Find a solution to use swipe without show error on code

Event handler simplification:

  • src/routes/+layout.svelte: Remove error from the swipeleft and swiperight event handlers adding them to custom-events.d.ts file, so now typescript can recognize those events.
Before After
image image

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Nov 13, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Nov 14, 2024
@stavares843 stavares843 merged commit 94d71d3 into dev Nov 14, 2024
7 checks passed
@stavares843 stavares843 deleted the fix-warnings-on-console branch November 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants