Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(profile): add PIN confirmation for account deletion and enhance settings UI #850

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat(profile): add PIN confirmation for account deletion and enhance settings UI #850

merged 5 commits into from
Nov 14, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Nov 13, 2024 •
edited
Loading

What this PR does 📖

1. Change delete account button to red (Showing that is a dangerous action)

Image

image

2. Add modal when user click on delete account button on profile page

  • If user type wrong pin, it will show a error toast message:

    Video showing behavior

    Screen.Recording.2024-11-13.at.10.17.06.mov

  • If user type correct pin, it will delete account permanently:

    Video showing behavior

    Screen.Recording.2024-11-13.at.10.18.00.mov

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Nov 13, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

stavares843
stavares843 requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing asking pin on the pin page as phil mentioned here
#848

video

Gravacao.do.ecra.2024-11-13.as.16.35.20.mov

browser - chrome

@stavares843 stavares843 added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 13, 2024
@lgmarchi
Copy link
Collaborator Author

missing asking pin on the pin page as phil mentioned here #848

video

Gravacao.do.ecra.2024-11-13.as.16.35.20.mov
browser - chrome

Added.

@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Nov 13, 2024
@stavares843 stavares843 removed the ⌨️ Ready for Test PR is ready for test label Nov 13, 2024
stavares843
stavares843 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if you sign up > pin page > dont add a pin > delete account > will ask you a pin but there is no pin defined yet but if you add any pin deletes the account regardless

im fine with improving this later

one suggestion would be, maybe if no pin is defined yet while user is still on sign up, dont ask pin

Gravacao.do.ecra.2024-11-13.as.16.43.38.mov

@stavares843
Copy link
Member

just let me know if you wanna address that here or on another PR @lgmarchi to know if we should add another ticket

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Nov 13, 2024
stavares843
stavares843 requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just let me know if you wanna address that here or on another PR @lgmarchi to know if we should add another ticket

@stavares843 stavares843 added question Further information is requested and removed QA Approved PR has been tested by QA Team labels Nov 13, 2024
@lgmarchi
Copy link
Collaborator Author

just let me know if you wanna address that here or on another PR @lgmarchi to know if we should add another ticket

I did changes you requested following your suggestion.

@lgmarchi lgmarchi added the ⌨️ Ready for Test PR is ready for test label Nov 13, 2024
@stavares843 stavares843 added being tested and removed ⌨️ Ready for Test PR is ready for test question Further information is requested labels Nov 13, 2024
@stavares843 stavares843 added QA Approved PR has been tested by QA Team and removed being tested labels Nov 13, 2024
@stavares843 stavares843 merged commit 9ecaafe into dev Nov 14, 2024
7 checks passed
@stavares843 stavares843 deleted the add-pin-before-delete-account branch November 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@ashneverdawn ashneverdawn ashneverdawn approved these changes

Assignees

@lgmarchi lgmarchi

Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task(DeleteAccount): Require that PIN be typed in before account is deleted
4 participants
@lgmarchi @stavares843 @ashneverdawn @phillsatellite