Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(profile): delete account #826

Merged
merged 6 commits into from
Nov 11, 2024
Merged

chore(profile): delete account #826

merged 6 commits into from
Nov 11, 2024

Conversation

stavares843
Copy link
Member

@stavares843 stavares843 commented Nov 9, 2024 •
edited
Loading

What this PR does 📖

Gravacao.do.ecra.2024-11-11.as.13.25.06.mov

User can delete account on profile.

How to test

  • sign up
  • profile
  • delete account
  • account should delete properly and go again automatically to create new account and user should be able to do a new account as well

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 9, 2024
@phillsatellite phillsatellite added the 📄 Draft PR is not ready yet label Nov 9, 2024
@stavares843 stavares843 removed the Missing dev review Two dev reviews are required on PR label Nov 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

dariusc93
dariusc93 reviewed Nov 9, 2024
View reviewed changes
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to delete tesseract too

@stavares843 stavares843 marked this pull request as ready for review November 11, 2024 13:31
@stavares843 stavares843 added being tested and removed 📄 Draft PR is not ready yet labels Nov 11, 2024
dariusc93
dariusc93 reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. I would suggest locking tesseract prior to clearing it (although it probably wouldnt matter right now if it is cleared externally or using tesseract functions).

src/routes/settings/profile/+page.svelte Show resolved Hide resolved
@stavares843 stavares843 merged commit 76cfd93 into dev Nov 11, 2024
11 checks passed
@stavares843 stavares843 deleted the sara/delete-account-button branch November 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 left review comments

@luisecm luisecm luisecm approved these changes

Assignees

@stavares843 stavares843

Labels
being tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stavares843 @dariusc93 @luisecm @phillsatellite