fix(Call): Fix flash talk indicator

[lgmarchi]

What this PR does 📖

This pull request introduces several enhancements and bug fixes to the src/lib/media/Voice.ts file, including the addition of voice activity detection, improvements to relay server testing, and updates to audio handling. Additionally, there are updates to the package.json and vite.config.js files to support these changes.

Voice Activity Detection:

• Added the voice-activity-detection library to detect when a user is speaking and update the media state accordingly. [1] [2]

Relay Server Testing:

• Introduced a method to test the connectivity of relay servers and update the list of available relays dynamically. [1] [2]

Audio Handling:

• Simplified audio constraints by removing specific audio settings such as echo cancellation and noise suppression.
• Added handling for receiving tracks from peers and logging the events.

Configuration Updates:

• Updated package.json to include the voice-activity-detection library.
• Modified vite.config.js to include voice-activity-detection in optimized dependencies.

Which issue(s) this PR fixes 🔨

• Resolve bug(calling): Voice indicator just blinks  #821

Special notes for reviewers 🗒️

Additional comments 🎤

[github-actions]

Download the app installers for this pull request:

• build-macos.zip
• build-windows.zip
• build-ubuntu.zip
• build-android.zip

[github-actions]

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

[phillsatellite]

Hey Lucas! So during testing Sara, Luis and I have found that friending is not working on this pr. Due to this its not possible to test the talking indicator

We tried old accounts and new accounts, and made sure to do npm i

User A sends UserB a friend request
User B accepts request
User A appears on User B side but User B does not appear on User A side

We tried moving to different page, refreshing browser and nothing gets User B to appear on User A side

I also tried 2 new accounts before testing this and 2 new accounts before verifying on dev that friending still worked so clean builds before attempting both

Your branch:

Screen_Recording_2024-11-08_at_5.50.39_PM.mov

Dev branch:

[stavares843]

phil added a comment above

[luisecm]

Hey Lucas! So during testing Sara, Luis and I have found that friending is not working on this pr. Due to this its not possible to test the talking indicator

We tried old accounts and new accounts, and made sure to do npm i

User A sends UserB a friend request User B accepts request User A appears on User B side but User B does not appear on User A side

We tried moving to different page, refreshing browser and nothing gets User B to appear on User A side

I also tried 2 new accounts before testing this and 2 new accounts before verifying on dev that friending still worked so clean builds before attempting both

Your branch:

Screen_Recording_2024-11-08_at_5.50.39_PM.mov

Dev branch:

Hello @lgmarchi just wanted to add that the automated tests are failing against this branch for the same reason mentioned above by Phil. I have not seen this error presented in the latest runs of automation tests against dev or any other prs

[lgmarchi]

Hey Lucas! So during testing Sara, Luis and I have found that friending is not working on this pr. Due to this its not possible to test the talking indicator

We tried old accounts and new accounts, and made sure to do npm i

User A sends UserB a friend request User B accepts request User A appears on User B side but User B does not appear on User A side

We tried moving to different page, refreshing browser and nothing gets User B to appear on User A side

I also tried 2 new accounts before testing this and 2 new accounts before verifying on dev that friending still worked so clean builds before attempting both

Your branch:

Screen_Recording_2024-11-08_at_5.50.39_PM.mov

Dev branch:

I pushed a commit to solve it.

[stavares843]

do we need the empty line here?

[stavares843]

the code comments seems a bit extensive

[phillsatellite]

So the talking indicator is working a lot better but we ran into some other issues when testing (Attempted with new accounts before testing pr, then verified on dev with the same accounts + new ones)

Issue:
It seems like after the first call is made and connected, any call after that don't seem to go through. I tried replicating this issue on dev but the dev branch works fine

Steps to reproduce:

• UserA calls User B - then after call is connected either person hangs up
• UserB calls back UserA - call does not go through
• UserA now tries to call UserB again and call does not go through

Logs:
UserA

UserB

Screen recordings:
This branch

Branch.mov

Dev branch

DevBranch.mov

[luisecm]

I see that friend requests are working again within latest commit

[lgmarchi]

So the talking indicator is working a lot better but we ran into some other issues when testing (Attempted with new accounts before testing pr, then verified on dev with the same accounts + new ones)

Issue: It seems like after the first call is made and connected, any call after that don't seem to go through. I tried replicating this issue on dev but the dev branch works fine

Steps to reproduce:

• UserA calls User B - then after call is connected either person hangs up
• UserB calls back UserA - call does not go through
• UserA now tries to call UserB again and call does not go through

Logs: UserA

UserB

Screen recordings: This branch

Branch.mov
Dev branch

DevBranch.mov

I pushed a commit that should solve that.

[stavares843]

so like @phillsatellite and i tested and i was talking to phil audio was pretty high but on my user there was zero indicator on my user

there was on phil side though and on phil side when he spoke he mentioned he had a talking indicator on his user

[lgmarchi]

so like @phillsatellite and i tested and i was talking to phil audio was pretty high but on my user there was zero indicator on my user

there was on phil side though and on phil side when he spoke he mentioned he had a talking indicator on his user

So the problem is, when you are talking, no indicator appears to you for your user?

[stavares843]

that is correct

[lgmarchi]

that is correct

Which browser? And is it private?

[stavares843]

chrome, macOS

private browser yes

[lgmarchi]

chrome, macOS

private browser yes

Try on normal browser, I am not sure on private it should works nice.

I did 3 tests now with @tooshel , worked all of them, including private browser too.

More thoughts about it? Want to test with other users?

[stavares843]

we approved for now, maybe we can improve in the future