Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(Logger): Add file and line information to log entries when is error or warning #822

Merged
merged 2 commits into from
Nov 8, 2024
Merged

update(Logger): Add file and line information to log entries when is error or warning #822

merged 2 commits into from
Nov 8, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Nov 7, 2024

No description provided.

@lgmarchi lgmarchi self-assigned this Nov 7, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Nov 7, 2024
stavares843
stavares843 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev

image

vs this PR

image

same error, with the file location

approved

@stavares843 stavares843 merged commit b972418 into dev Nov 8, 2024
7 checks passed
@stavares843 stavares843 deleted the improve-logs-for-errors-and-warnings branch November 8, 2024 17:19
@lgmarchi lgmarchi removed the Missing dev review Two dev reviews are required on PR label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@ashneverdawn ashneverdawn ashneverdawn approved these changes

Assignees

@lgmarchi lgmarchi

Labels
QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgmarchi @ashneverdawn @stavares843 @phillsatellite