Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(mobile): fix status bar overlapping in ios #820

Closed
wants to merge 7 commits into from

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented Nov 6, 2024

What this PR does 📖

  • Fixing overlapping status bar on ios newer versions of the app and ensured that this is not breaking android app

Before:
image

After:
image

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Download the app installers for this pull request:

@phillsatellite
Copy link
Contributor

Sent Luis a message it seems like the download bar at the top of the app is missing or not visible on this branch

Screenshot 2024-11-06 at 2 57 41 PM

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 6, 2024
@luisecm luisecm added the 📄 Draft PR is not ready yet label Nov 6, 2024
@stavares843 stavares843 removed the Missing dev review Two dev reviews are required on PR label Nov 7, 2024
@luisecm luisecm removed 📄 Draft PR is not ready yet QA Requested Changes Changes need to be addressed, something is not working as expected. labels Nov 7, 2024
@luisecm
Copy link
Contributor Author

luisecm commented Nov 7, 2024

@phillsatellite Fixed your comments, please let me know if that works

Copy link

github-actions bot commented Nov 7, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite phillsatellite added the Missing dev review Two dev reviews are required on PR label Nov 7, 2024
@phillsatellite
Copy link
Contributor

Already been talking to Luis about this. Seems theres a little debugging to do to figure out why its rendering the top behind the dynamic island

image

image

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. 📄 Draft PR is not ready yet labels Nov 7, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Draft PR is not ready yet Missing dev review Two dev reviews are required on PR Missing fixing conflict Needs to fix conflicts QA Requested Changes Changes need to be addressed, something is not working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants