Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependency): update wasm to 1.5.1 #814

Merged
merged 4 commits into from
Nov 5, 2024
Merged

chore(dependency): update wasm to 1.5.1 #814

merged 4 commits into from
Nov 5, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does πŸ“–

  • Updates wasm to 1.5.1

Special notes for reviewers πŸ—’οΈ

  • Group permission was redone and is now user based instead of global. We need to adjust the ui before we can make use of that. For this PR i disabled group permission modification

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Nov 4, 2024
@luisecm
Copy link
Contributor

luisecm commented Nov 4, 2024

@Flemmli97 Hey Kevin, I noticed the following error caught by the automated tests when removing the seed phrase:

This error is not happening in dev

Grabacion.de.pantalla.2024-11-04.a.la.s.5.57.35.p.m.mov

image

@stavares843 stavares843 added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 5, 2024
@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Nov 5, 2024
@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed Missing dev review Two dev reviews are required on PR labels Nov 5, 2024
@phillsatellite phillsatellite added being tested and removed ⌨️ Ready for Test PR is ready for test labels Nov 5, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Nov 5, 2024

This seems to break chats. When you try to start one nothing happens and you get errors in console (see image below) Haven't been able to test anything in chats due to this

Screen.Recording.2024-11-05.at.11.03.21.AM.mov
Screenshot 2024-11-05 at 11 02 35β€―AM

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed being tested labels Nov 5, 2024
@luisecm
Copy link
Contributor

luisecm commented Nov 5, 2024

@Flemmli97 Hey Kevin, I noticed the following error caught by the automated tests when removing the seed phrase:

This error is not happening in dev

Grabacion.de.pantalla.2024-11-04.a.la.s.5.57.35.p.m.mov
image

I see that this is fixed in the latest commit, thanks! @Flemmli97

@Flemmli97
Copy link
Contributor Author

This seems to break chats. When you try to start one nothing happens and you get errors in console (see image below) Haven't been able to test anything in chats due to this

Screen.Recording.2024-11-05.at.11.03.21.AM.mov

Screenshot 2024-11-05 at 11 02 35β€―AM

This seems to break chats. When you try to start one nothing happens and you get errors in console (see image below) Haven't been able to test anything in chats due to this

Screen.Recording.2024-11-05.at.11.03.21.AM.mov

Screenshot 2024-11-05 at 11 02 35β€―AM

have you updated the packages? cause that method is in newer wasm.
try deleting the node_modules folder and run npm i

@phillsatellite phillsatellite added being tested and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Nov 5, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed being tested labels Nov 5, 2024
@phillsatellite phillsatellite merged commit e81b45a into dev Nov 5, 2024
11 checks passed
@phillsatellite phillsatellite deleted the update-wasm branch November 5, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants