Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calling): call video select #811

Merged
merged 1 commit into from
Nov 4, 2024
Merged

feat(calling): call video select #811

merged 1 commit into from
Nov 4, 2024

Conversation

Flemmli97
Copy link
Contributor

@Flemmli97 Flemmli97 commented Nov 1, 2024 •
edited
Loading

What this PR does 📖

  • Clicking on a user/video in calling will enlarge it. When enlarged will not show other users screen. Clicking on it again will revert ui back to before
  • Also fix ui for pending users in calling

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Nov 1, 2024
@lgmarchi lgmarchi added Ready to Merge This PR is tested and ready for merge Missing dev review Two dev reviews are required on PR and removed Missing dev review Two dev reviews are required on PR Ready to Merge This PR is tested and ready for merge labels Nov 4, 2024
@lgmarchi
Copy link
Collaborator

lgmarchi commented Nov 4, 2024

  • Code is good, and worked as expected.
Screen.Recording.2024-11-04.at.16.18.31.mov

@lgmarchi lgmarchi added Ready to Merge This PR is tested and ready for merge and removed Missing dev review Two dev reviews are required on PR labels Nov 4, 2024
@stavares843 stavares843 merged commit d936341 into dev Nov 4, 2024
25 checks passed
@stavares843 stavares843 deleted the video-select branch November 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@lgmarchi lgmarchi lgmarchi approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
QA Approved PR has been tested by QA Team Ready to Merge This PR is tested and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(calling): highlight video
4 participants
@Flemmli97 @lgmarchi @phillsatellite @stavares843