fix(groups): group user list

[Flemmli97]

What this PR does 📖

• Fix group participants inconsistency:

  • It was possible to "remove" (only visually) users by clicking on the user list instead of the buttons on top

• Resolve bug(Groups): Cannot add friend to already existing groups #764 764

[github-actions]

Download the app installers for this pull request:

• build-macos.zip
• build-windows.zip
• build-ubuntu.zip
• build-android.zip

[github-actions]

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

[phillsatellite]

Hey Kevin! I think this bug fits the scope of this pr but we can handle it in another ticket if need be. So while testing it seems removing a user on the top bar will work fine but if you scroll through the list and remove them from there it doesn't actually remove them it will just reselect them

Screen.Recording.2024-11-01.at.12.51.17.PM.mov

[Flemmli97]

Hey Kevin! I think this bug fits the scope of this pr but we can handle it in another ticket if need be. So while testing it seems removing a user on the top bar will work fine but if you scroll through the list and remove them from there it doesn't actually remove them it will just reselect them

Screen.Recording.2024-11-01.at.12.51.17.PM.mov

yes thats intended. the list shows ALL friends of yours. if they are selected they are in the group

[phillsatellite]

Hey Kevin! I think this bug fits the scope of this pr but we can handle it in another ticket if need be. So while testing it seems removing a user on the top bar will work fine but if you scroll through the list and remove them from there it doesn't actually remove them it will just reselect them
Screen.Recording.2024-11-01.at.12.51.17.PM.mov

yes thats intended. the list shows ALL friends of yours. if they are selected they are in the group

Yeah I see the list shows all your friends but check out the video I added again. If you try to unselect someone from the list it just re adds them quickly same with trying to select someone from the list when you click them it'll select them for a moment and then unselect them

[lgmarchi]

@Flemmli97 It just work to add a user to the group, but it does not work to remove user from a group.

See the video video below to understand:

Screen.Recording.2024-11-05.at.13.26.26.mov

[Flemmli97]

@Flemmli97 It just work to add a user to the group, but it does not work to remove user from a group.

See the video video below to understand:

Screen.Recording.2024-11-05.at.13.26.26.mov

hmm its working on my end

2024-11-05.17-34-02.mp4

can you post the logs?

[lgmarchi]

There are some changes necessary yet.

[lgmarchi]

@Flemmli97 It just work to add a user to the group, but it does not work to remove user from a group.
See the video video below to understand:
Screen.Recording.2024-11-05.at.13.26.26.mov

hmm its working on my end

2024-11-05.17-34-02.mp4
can you post the logs?

Never mind, probably was a cache problem here. Now it is working good.

[lgmarchi]

Code looks good and it is working as expected as well.

Screen.Recording.2024-11-05.at.14.18.53.mov

[stavares843]

Gravacao.do.ecra.2024-11-05.as.23.57.38.mov

does not work if you are not the group creator

flow

• someone else creates the group
• try to do the above flow
• it removes and after some seconds adds right away

only works if you are the group creator

[Flemmli97]

Gravacao.do.ecra.2024-11-05.as.23.57.38.mov
does not work if you are not the group creator

flow

• someone else creates the group
• try to do the above flow
• it removes and after some seconds adds right away

only works if you are the group creator

yes. permission got redone with new wasm update

[Flemmli97]

i would suggest we keep this pr as is as ill address the permission thing in another pr

[stavares843]

added blocked label, being discussed with flem

[stavares843]

after discussing with flem, merging as is and will fix the non admin stuff in another PR