Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(groups): deactivate button if there are no users on list #784

Merged
merged 11 commits into from
Oct 31, 2024

Conversation

stavares843
Copy link
Member

What this PR does 📖

deactivate button if there are no users on list

Gravacao.do.ecra.2024-10-28.as.19.22.51.mov

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 28, 2024
Copy link

github-actions bot commented Oct 28, 2024

Download the app installers for this pull request:

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 28, 2024
Copy link

github-actions bot commented Oct 28, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@luisecm
Copy link
Contributor

luisecm commented Oct 28, 2024

The test failing in your branch is expected since currently the test is clicking on create group button even on negative scenarios when name is empty - Already fixing this here Satellite-im/automated-tests-web#190

@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Oct 29, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 29, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Oct 29, 2024
@stavares843 stavares843 merged commit 2a8f2fe into dev Oct 31, 2024
9 of 11 checks passed
@stavares843 stavares843 deleted the sara/deactivate-button-if-no-users-on-list branch October 31, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Automated Test Failed Automated Tests CI Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants