feat(calling): join/leave sound #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
github-actions
bot
added
the
Missing dev review
|
Download the app installers for this pull request: |
lgmarchi
reviewed
Oct 24, 2024
| @@ -194,6 +195,7 @@ export class CallRoom { | |||
| let stream = await VoiceRTCInstance.getLocalStream() | |||
| log.debug(`Sending local stream ${stream} to ${peer}`) | |||
| room.addStream(stream, peer) | |||
| playSound(Sounds.Joined) | |||
There was a problem hiding this comment.
Kevin, I think we can move it to other place, because here, is just when person is really inside the room, and not when person accept call
There was a problem hiding this comment.
i think this is fine because its when the user then is actually inside the room. accepting the call doesnt mean at that moment the user is actually in the call
There was a problem hiding this comment.
I agree, you are correct.
phillsatellite
added
the
QA Requested Changes
|
Label added for Lucas's comment |
lgmarchi
removed
the
QA Requested Changes
lgmarchi
approved these changes
Oct 25, 2024
stavares843
approved these changes
Oct 25, 2024
phillsatellite
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖