Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): wire up button sounds #729

Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat(settings): wire up button sounds #729

merged 7 commits into from
Oct 18, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Wires up the interface sound setting. Buttons and Switches now play a sound when clicked

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Download the app installers for this pull request:

lgmarchi
lgmarchi approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@lgmarchi lgmarchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

Did you test with buttons that already have a sound?

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 17, 2024
@Flemmli97
Copy link
Contributor Author

Very good!

Did you test with buttons that already have a sound?

updated to consider that

@phillsatellite phillsatellite added ⌨️ Ready for Test PR is ready for test and removed Missing dev review Two dev reviews are required on PR labels Oct 17, 2024
@phillsatellite
Copy link
Contributor

phillsatellite commented Oct 17, 2024 •
edited
Loading

Hey Kevin! Just one minor thing, the interface sounds will persist even while turned off

Screen.Recording.2024-10-17.at.3.35.00.PM.mov

@phillsatellite phillsatellite added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed ⌨️ Ready for Test PR is ready for test labels Oct 17, 2024
@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 18, 2024
@phillsatellite phillsatellite merged commit 84b6843 into dev Oct 18, 2024
7 checks passed
@phillsatellite phillsatellite deleted the button-sounds branch October 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@lgmarchi lgmarchi lgmarchi approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
being tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(add): Interface sounds
5 participants
@Flemmli97 @phillsatellite @lgmarchi @stavares843 @luisecm