Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Call): Fix call sounds in general #719

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Oct 15, 2024

What this PR does 📖

  • Fix call sounds in general

  • Add sound when we make call

  • Add hack way to user allow sound for call if user click or touch in the screen (If you refresh page, and click on screen, incoming call sound will work, if not, it will come without sound)

  • Stop incoming call sound, if userA cancel the call, just let UI feedback for userB

  • Stop sound when at least 1 user accept the call, and show feedback to user that made the call that user accepted the call

image
  • Bonus: Set callTimeout variable to false, after call is accepted

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Oct 15, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 15, 2024
Copy link

github-actions bot commented Oct 15, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 15, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite
Copy link
Contributor

phillsatellite commented Oct 15, 2024

Hey Lucas! So this pr was a little shady Luis Sara and I all tested and had different experience's

Sara:
For either ringtone for both the user making the call and the user receiving the call were not working. She was testing on Opera and tried new accounts and also refreshing

Luis:
Luis could only hear the normal incoming call ringtone when he made the call from Firefox to Brave. Vise Versa it did not work - Edit - Luis was most of the times able to hear one sound, not both. He even tried testing using different devices calling themselves

Me:
I was able to hear both the ringtone for user making the call and user receiving the call but after the user receiving the call would answer, the ringtone for the user making the call would still persist. I tested on both Chrome & Brave

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 15, 2024
@phillsatellite
Copy link
Contributor

We have retested and got it working for just about everyone. The only bug we have noticed now that Lucas is already aware of is the ringtone for the user will persist after the call is picked up

@lgmarchi lgmarchi added ⌨️ Ready for Test PR is ready for test and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 16, 2024
@lgmarchi
Copy link
Collaborator Author

We have retested and got it working for just about everyone. The only bug we have noticed now that Lucas is already aware of is the ringtone for the user will persist after the call is picked up

Solved!

@phillsatellite phillsatellite added being tested and removed Missing dev review Two dev reviews are required on PR ⌨️ Ready for Test PR is ready for test labels Oct 16, 2024
@phillsatellite phillsatellite added Ready to Merge This PR is tested and ready for merge and removed being tested labels Oct 16, 2024
@phillsatellite phillsatellite merged commit 83c48a8 into dev Oct 16, 2024
7 checks passed
@phillsatellite phillsatellite deleted the fix-soundcall-in-general branch October 16, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge This PR is tested and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(Call): Problem with call sounds when call and when receive call after a refresh
3 participants