-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Call): Fix call sounds in general #719
Conversation
Download the app installers for this pull request: |
Hey Lucas! So this pr was a little shady Luis Sara and I all tested and had different experience's Sara: Luis: Me: |
We have retested and got it working for just about everyone. The only bug we have noticed now that Lucas is already aware of is the ringtone for the user will persist after the call is picked up |
Solved! |
What this PR does 📖
Fix call sounds in general
Add sound when we make call
Add hack way to user allow sound for call if user click or touch in the screen (If you refresh page, and click on screen, incoming call sound will work, if not, it will come without sound)
Stop incoming call sound, if userA cancel the call, just let UI feedback for userB
Stop sound when at least 1 user accept the call, and show feedback to user that made the call that user accepted the call
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤