Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): impl file sharing chat #704

Merged
merged 10 commits into from
Oct 17, 2024
Merged

feat(chat): impl file sharing chat #704

merged 10 commits into from
Oct 17, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Implements file sharing button for files in chat
    • Adds back the share button for file type attachments (image e.g. dont have this)
    • Clicking on it opens a share modal where you can select multiple chats
    • Sending it will send the file to all selected chats

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 14, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 14, 2024
@Flemmli97 Flemmli97 removed the Missing fixing conflict Needs to fix conflicts label Oct 15, 2024
@phillsatellite
Copy link
Contributor

@Flemmli97 Im getting some weird behavior when trying to test this. Sometimes the attachment will send through but most times it will not. Ive tried this on Safari/Chrome/Brave Ive done all new accounts, Ive also tried refreshing the accounts if need be

When the attachment doesnt send it just sends a blank bubble in the chat and this error appears in console

Logger.ts:46 [ERROR] (12:44:45 PM): Error uploading file No attachments provided for message

Screen.Recording.2024-10-15.at.12.44.41.PM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 15, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 16, 2024
@phillsatellite phillsatellite removed the Missing dev review Two dev reviews are required on PR label Oct 16, 2024
@github-actions github-actions bot added Failed Automated Test Failed Automated Tests CI and removed Missing fixing conflict Needs to fix conflicts labels Oct 17, 2024
@phillsatellite
Copy link
Contributor

@Flemmli97 Retested with Sara and we both had a lot of issues

When you try to send a file it doesnt seem to be sending correctly. User will get a notification like they got a new message but when they go to chat no new message appears only the banner that says "new message"

After the sender sends a file it kinda breaks the entire app. User cannot use the nav bar to navigate anymore, if they refresh chat either endlessly loads or just loads a black screen.

It was throwing these errors in logs for both Sara and I
Screenshot 2024-10-17 at 12 14 52 PM

Screen.Recording.2024-10-17.at.12.08.29.PM.mov

@luisecm
Copy link
Contributor

luisecm commented Oct 17, 2024

@Flemmli97 Automation test caught the following bug:

  1. Go to chat
  2. Select upload file and pickup any file
  3. Then select upload file and pickup another file
  4. Chatbar preview before sending message includes two attachment previews
  5. Click on send message
  6. Message with the two attachments is not sent and chatbar preview disappears

@Flemmli97
Copy link
Contributor Author

@Flemmli97 Retested with Sara and we both had a lot of issues

When you try to send a file it doesnt seem to be sending correctly. User will get a notification like they got a new message but when they go to chat no new message appears only the banner that says "new message"

After the sender sends a file it kinda breaks the entire app. User cannot use the nav bar to navigate anymore, if they refresh chat either endlessly loads or just loads a black screen.

It was throwing these errors in logs for both Sara and I Screenshot 2024-10-17 at 12 14 52 PM

Screen.Recording.2024-10-17.at.12.08.29.PM.mov

fixed. was a bug from merging

@github-actions github-actions bot removed the Failed Automated Test Failed Automated Tests CI label Oct 17, 2024
@phillsatellite phillsatellite added QA Approved PR has been tested by QA Team and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 17, 2024
@InfamousVague InfamousVague merged commit cc08920 into dev Oct 17, 2024
10 checks passed
@InfamousVague InfamousVague deleted the file_share branch October 17, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(Chat): Wire up Share Files
4 participants