Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Call): Fix problem that made new call when back to chat #701

Closed
wants to merge 18 commits into from

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Oct 11, 2024

What this PR does 📖

  • Fix problem that made new call when back to chat

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Oct 11, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 11, 2024

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@phillsatellite
Copy link
Contributor

There was just a couple minor issues we spotted while testing

There was no audio when calling. User could hear the ringtone but then when you join the call there is no audio

Second issue was the call timer is resetting when the user goes to Settings/Back to chat

Flow is
user starts call
Navs to settings
Back to chat
Call Timer resets

Gravacao_do_ecra_2024-10-14_as_19.36.56.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 14, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 14, 2024
@phillsatellite
Copy link
Contributor

Lucas had requested we close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR Missing fixing conflict Needs to fix conflicts QA Requested Changes Changes need to be addressed, something is not working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Calling): New call starts when going back to chat
3 participants