-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): update emoji picker #689
Conversation
Download the app installers for this pull request: |
Automated Test Results 1 failed Details 125 tests across 16 suites Failed testsAutomated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B66 - Sending and receiving emojis and emoji picker tests Skipped testsAutomated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note |
Playwright test execution is complete! You can find the test results report here |
Sara and I did some testing together and we both had the same behavior we select skin tone but it is not applied to selected emoji. We tested this on Chrome, Brave, Safari and Opera Screen.Recording.2024-10-10.at.1.18.50.PM.mov |
@Flemmli97 There is one automated test currently failing on your branch because the Frequently Used emojis have 5 now by default and therefore the count of emojis frequently used test is not matching with the current expectation from the tests. I have a PR to update the tests in case your pr is merged - Satellite-im/automated-tests-web#179 |
ye we kinda duplicated the stuff there. we already had a "freq used" data saved (emoji counter) |
those emoji do not have skin colors. scroll down a bit |
What this PR does 📖
Which issue(s) this PR fixes 🔨