Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): update emoji picker #689

Merged
merged 7 commits into from
Oct 14, 2024
Merged

fix(chat): update emoji picker #689

merged 7 commits into from
Oct 14, 2024

Conversation

Flemmli97
Copy link
Contributor

What this PR does 📖

  • Remove duplicate emoji counter that already existed in UIStore
  • Make skintone selection persistent

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 10, 2024

Automated Test Results

failed  1 failed
passed  109 passed
skipped  15 skipped

Details

stats  125 tests across 16 suites
duration  14 minutes, 20 seconds
commit  1b6ee50

Failed tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B66 - Sending and receiving emojis and emoji picker tests

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K2 - Font dropdown should show expected font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K15 - Emoji Font dropdown should show expected emoji font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K18 - Default Profile Picture Style dropdown should show expected default profile picture styles
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O1, 06 - Message at top of page and custom keybinds listed correctly
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O2, 04 - Clicking a key should activate the Recorded Keys - User can save keybind
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O3 - Action dropdown should display correct keybind actions
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O5 - Clicking Cancel should cancel any custom keybinding the user was trying to add
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O7 - Highlighted border should display when user clicks cancel
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O8 - Clicking Revert Keybindings should revert any custom keybindings the user has saved
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O9 - Highlighted border should be displayed when clicking Revert Keybindings
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O10 - Clicking the backwards arrow should revert specific custom keybinding
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

Playwright test execution is complete! You can find the test results report here

@phillsatellite
Copy link
Contributor

phillsatellite commented Oct 10, 2024

Sara and I did some testing together and we both had the same behavior we select skin tone but it is not applied to selected emoji.

We tested this on Chrome, Brave, Safari and Opera

Screen.Recording.2024-10-10.at.1.18.50.PM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 10, 2024
@luisecm
Copy link
Contributor

luisecm commented Oct 11, 2024

@Flemmli97 There is one automated test currently failing on your branch because the Frequently Used emojis have 5 now by default and therefore the count of emojis frequently used test is not matching with the current expectation from the tests. I have a PR to update the tests in case your pr is merged - Satellite-im/automated-tests-web#179

@Flemmli97
Copy link
Contributor Author

@Flemmli97 There is one automated test currently failing on your branch because the Frequently Used emojis have 5 now by default and therefore the count of emojis frequently used test is not matching with the current expectation from the tests. I have a PR to update the tests in case your pr is merged - Satellite-im/automated-tests-web#179

ye we kinda duplicated the stuff there. we already had a "freq used" data saved (emoji counter)

@Flemmli97 Flemmli97 added QA Requested Changes Changes need to be addressed, something is not working as expected. and removed QA Requested Changes Changes need to be addressed, something is not working as expected. labels Oct 11, 2024
@Flemmli97
Copy link
Contributor Author

Sara and I did some testing together and we both had the same behavior we select skin tone but it is not applied to selected emoji.

We tested this on Chrome, Brave, Safari and Opera

Screen.Recording.2024-10-10.at.1.18.50.PM.mov

those emoji do not have skin colors. scroll down a bit

@Flemmli97 Flemmli97 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 11, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Oct 11, 2024
@lgmarchi lgmarchi removed the Missing dev review Two dev reviews are required on PR label Oct 14, 2024
@stavares843 stavares843 merged commit 6378274 into dev Oct 14, 2024
5 of 7 checks passed
@stavares843 stavares843 deleted the emoji_picker branch October 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Automated Test Failed Automated Tests CI QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(emojis): skin tone selected is not preserved after closing emoji picker
5 participants