Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(relay): fix warning #686

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore(relay): fix warning #686

merged 1 commit into from
Oct 8, 2024

Conversation

stavares843
Copy link
Member

What this PR does 📖

fix warning on npm run dev

how to test

  • npm run build
  • this warning should not appear
Captura de ecrã 2024-10-08, às 23 39 20
  • relay stuff should be the same as dev

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 8, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Build Log Differences Found:

3,9d2
< 10:41:41 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/components/ui/RelaySelector.svelte:359:0 Unused CSS selector ".relay-selector .filling"
< 357:   align-self: flex-end;
< 358: }
< 359: .relay-selector .filling {
<      ^
< 360:   width: 100%;
< 361: }

@stavares843 stavares843 merged commit 2fa0842 into dev Oct 8, 2024
8 checks passed
@stavares843 stavares843 deleted the sara/fix-warning-relay branch October 8, 2024 22:44
Copy link

github-actions bot commented Oct 8, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 8, 2024

Automated Test Results

passed  110 passed
skipped  15 skipped

Details

stats  125 tests across 16 suites
duration  13 minutes, 17 seconds
commit  6a90033

Skipped tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K2 - Font dropdown should show expected font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K15 - Emoji Font dropdown should show expected emoji font names
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K18 - Default Profile Picture Style dropdown should show expected default profile picture styles
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O1, 06 - Message at top of page and custom keybinds listed correctly
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O2, 04 - Clicking a key should activate the Recorded Keys - User can save keybind
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O3 - Action dropdown should display correct keybind actions
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O5 - Clicking Cancel should cancel any custom keybinding the user was trying to add
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O7 - Highlighted border should display when user clicks cancel
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O8 - Clicking Revert Keybindings should revert any custom keybindings the user has saved
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O9 - Highlighted border should be displayed when clicking Revert Keybindings
Automated Tests on Chrome Desktop › 13-settings-keybinds.spec.ts › Settings Keybinds Tests › O10 - Clicking the backwards arrow should revert specific custom keybinding
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

Copy link

github-actions bot commented Oct 8, 2024

Playwright test execution is complete! You can find the test results report here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants