-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(attachments): create attachments component to alleviate duplicate code #682
Conversation
Download the app installers for this pull request: |
Automated Test ResultsDetails Β 125 tests across 16 suites Skipped testsAutomated Tests on Chrome Desktop βΊ 03-friends-two-instances.spec.ts βΊ Two instances tests - Friends and Chats βΊ B8 to B14 - Quick Profile Local and Remote - Updating note |
Playwright test execution is complete! You can find the test results report here |
So functionality is working a lot better! Theres just one issue that doesnt happen on dev, if your browser is not fullscreen and you open up the attachment half of the preview will render behind the sidebar Screen.Recording.2024-10-08.at.6.39.15.PM.mov |
Build Log Differences Found: 2a3,9
> 3:29:21 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/components/messaging/AttachmentRenderer.svelte:157:0 Unused CSS selector "#page"
> 155: }
> 156:
> 157: #page {
> ^
> 158: display: flex;
> 159: min-width: 0; |
Build Log Differences Found: 2a3,9
> 5:39:29 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/components/messaging/AttachmentRenderer.svelte:157:0 Unused CSS selector "#page"
> 155: }
> 156:
> 157: #page {
> ^
> 158: display: flex;
> 159: min-width: 0; |
β¦ite-im/UplinkWeb into make-attachment-component
β¦ite-im/UplinkWeb into make-attachment-component
Hey @phillsatellite ! after a long battle with css and a boatload of merge issues I decided to have a little work around and it should be good now! |
β¦make-attachment-component
Build Log Differences Found: 2a3,23
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:997:0 Unused CSS selector "#page .unreads-since-container"
> 995: }
> 996: }
> 997: #page .unreads-since-container {
> ^
> 998: display: flex;
> 999: height: fit-content;
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:1003:0 Unused CSS selector "#page .unreads-since-container .unreads-since-line"
> 1001: margin-bottom: var(--padding-less);
> 1002: }
> 1003: #page .unreads-since-container .unreads-since-line {
> ^
> 1004: width: 100%;
> 1005: height: 1px;
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:1009:0 Unused CSS selector "#page .unreads-since-container .unreads-since"
> 1007: background-color: var(--color-muted);
> 1008: }
> 1009: #page .unreads-since-container .unreads-since {
> ^
> 1010: text-align: center;
> 1011: width: 100%; |
What this PR does π
Which issue(s) this PR fixes π¨
Special notes for reviewers ποΈ
For testing, attachments should look and function exactly how they already do.
Also, this pr is dependent on the #652 pr going in first
Additional comments π€