Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(attachments): create attachments component to alleviate duplicate code #682

Merged
merged 41 commits into from
Oct 14, 2024

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented Oct 7, 2024

What this PR does πŸ“–

  • create attachments component to alleviate duplicate code

Which issue(s) this PR fixes πŸ”¨

  • Resolve #
  • No resolve # for this issue

Special notes for reviewers πŸ—’οΈ

For testing, attachments should look and function exactly how they already do.

Also, this pr is dependent on the #652 pr going in first

Additional comments 🎀

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Download the app installers for this pull request:

Copy link

github-actions bot commented Oct 7, 2024

Automated Test Results

passed Β 110 passed
skipped Β 15 skipped

Details

stats Β 125 tests across 16 suites
duration Β 14 minutes, 56 seconds
commit Β d3866b2

Skipped tests

Automated Tests on Chrome Desktop β€Ί 03-friends-two-instances.spec.ts β€Ί Two instances tests - Friends and Chats β€Ί B8 to B14 - Quick Profile Local and Remote - Updating note
Automated Tests on Chrome Desktop β€Ί 03-friends-two-instances.spec.ts β€Ί Two instances tests - Friends and Chats β€Ί B8 to B14 - Quick Profile Local - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop β€Ί 03-friends-two-instances.spec.ts β€Ί Two instances tests - Friends and Chats β€Ί B8 to B14 - Quick Profile Remote - Updating username, status, banner and profile picture
Automated Tests on Chrome Desktop β€Ί 09-settings-customizations.spec.ts β€Ί Settings Customization Tests β€Ί K2 - Font dropdown should show expected font names
Automated Tests on Chrome Desktop β€Ί 09-settings-customizations.spec.ts β€Ί Settings Customization Tests β€Ί K15 - Emoji Font dropdown should show expected emoji font names
Automated Tests on Chrome Desktop β€Ί 09-settings-customizations.spec.ts β€Ί Settings Customization Tests β€Ί K18 - Default Profile Picture Style dropdown should show expected default profile picture styles
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O1, 06 - Message at top of page and custom keybinds listed correctly
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O2, 04 - Clicking a key should activate the Recorded Keys - User can save keybind
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O3 - Action dropdown should display correct keybind actions
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O5 - Clicking Cancel should cancel any custom keybinding the user was trying to add
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O7 - Highlighted border should display when user clicks cancel
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O8 - Clicking Revert Keybindings should revert any custom keybindings the user has saved
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O9 - Highlighted border should be displayed when clicking Revert Keybindings
Automated Tests on Chrome Desktop β€Ί 13-settings-keybinds.spec.ts β€Ί Settings Keybinds Tests β€Ί O10 - Clicking the backwards arrow should revert specific custom keybinding
Automated Tests on Chrome Desktop β€Ί 20-settings-developer.spec.ts β€Ί Settings Developer Tests β€Ί T4 - Clicking Clear State should clear users state

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Playwright test execution is complete! You can find the test results report here

@Satellite-im Satellite-im deleted a comment from github-actions bot Oct 8, 2024
@phillsatellite
Copy link
Contributor

So functionality is working a lot better! Theres just one issue that doesnt happen on dev, if your browser is not fullscreen and you open up the attachment half of the preview will render behind the sidebar

Screen.Recording.2024-10-08.at.6.39.15.PM.mov

Copy link

github-actions bot commented Oct 9, 2024

Build Log Differences Found:

2a3,9
> 3:29:21 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/components/messaging/AttachmentRenderer.svelte:157:0 Unused CSS selector "#page"
> 155: }
> 156: 
> 157: #page {
>      ^
> 158:   display: flex;
> 159:   min-width: 0;

Copy link

github-actions bot commented Oct 9, 2024

Build Log Differences Found:

2a3,9
> 5:39:29 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/lib/components/messaging/AttachmentRenderer.svelte:157:0 Unused CSS selector "#page"
> 155: }
> 156: 
> 157: #page {
>      ^
> 158:   display: flex;
> 159:   min-width: 0;

@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 9, 2024
@Jekrimo
Copy link
Contributor Author

Jekrimo commented Oct 10, 2024

Hey @phillsatellite ! after a long battle with css and a boatload of merge issues I decided to have a little work around and it should be good now!

@github-actions github-actions bot removed the Missing fixing conflict Needs to fix conflicts label Oct 10, 2024
@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 11, 2024
@phillsatellite phillsatellite removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Oct 11, 2024
Copy link

Build Log Differences Found:

2a3,23
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:997:0 Unused CSS selector "#page .unreads-since-container"
>  995:   }
>  996: }
>  997: #page .unreads-since-container {
>       ^
>  998:   display: flex;
>  999:   height: fit-content;
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:1003:0 Unused CSS selector "#page .unreads-since-container .unreads-since-line"
> 1001:   margin-bottom: var(--padding-less);
> 1002: }
> 1003: #page .unreads-since-container .unreads-since-line {
>       ^
> 1004:   width: 100%;
> 1005:   height: 1px;
> 3:53:33 PM [vite-plugin-svelte] /home/runner/work/UplinkWeb/UplinkWeb/src/routes/chat/+page.svelte:1009:0 Unused CSS selector "#page .unreads-since-container .unreads-since"
> 1007:   background-color: var(--color-muted);
> 1008: }
> 1009: #page .unreads-since-container .unreads-since {
>       ^
> 1010:   text-align: center;
> 1011:   width: 100%;

@github-actions github-actions bot removed the Missing fixing conflict Needs to fix conflicts label Oct 14, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Oct 14, 2024
@stavares843 stavares843 merged commit 7f004b3 into dev Oct 14, 2024
9 checks passed
@stavares843 stavares843 deleted the make-attachment-component branch October 14, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants